Problem/Motivation
The module currently uses V2 of the HIBP API, but there's now a V3.
https://haveibeenpwned.com/API/v3#PwnedPasswords
Proposed resolution
Update to use v3 of the API.
Remaining tasks
Do we need to change anything?
At a glance, the only difference I can see for the PwnedPasswords portion of the API is the addition of Add-Padding.
Perhaps we could add that as an option; I'd leave it disabled by default.
It looks like support for NTLM hashes has also been added, but that's not relevant to Drupal.
Add tests for any additional functionality.
User interface changes
Any additional options to be added to the admin UI.
API changes
Doesn't look like the version is included in the URL we send API requests to, so no need to change that?
Data model changes
n/a
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 3406766-4.patch | 9.36 KB | mcdruid |
Issue fork password_haveibeenpwned-3406766
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mcdruid commentedComment #3
mcdruid commentedComment #4
mcdruid commentedChanged my mind about the default for padding; I think it should be enabled.
Comment #6
mcdruid commentedComment #7
mcdruid commentedComment #8
mcdruid commentedAdding some more tests.
Comment #11
mcdruid commented