Problem/Motivation

The module currently uses V2 of the HIBP API, but there's now a V3.

https://haveibeenpwned.com/API/v3#PwnedPasswords

Proposed resolution

Update to use v3 of the API.

Remaining tasks

Do we need to change anything?

At a glance, the only difference I can see for the PwnedPasswords portion of the API is the addition of Add-Padding.

Perhaps we could add that as an option; I'd leave it disabled by default.

It looks like support for NTLM hashes has also been added, but that's not relevant to Drupal.

Add tests for any additional functionality.

User interface changes

Any additional options to be added to the admin UI.

API changes

Doesn't look like the version is included in the URL we send API requests to, so no need to change that?

Data model changes

n/a

CommentFileSizeAuthor
#4 3406766-4.patch9.36 KBmcdruid
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mcdruid created an issue. See original summary.

mcdruid’s picture

Issue summary: View changes
mcdruid’s picture

Issue summary: View changes
mcdruid’s picture

Status: Active » Needs review
StatusFileSize
new9.36 KB

Changed my mind about the default for padding; I think it should be enabled.

  • mcdruid committed 6a682d71 on 7.x-2.x
    Issue #3406766 by mcdruid: Upgrade to use V3 of the HIBP API, enable Add...
mcdruid’s picture

Status: Needs review » Fixed
mcdruid’s picture

Issue summary: View changes
mcdruid’s picture

Status: Fixed » Needs review

Adding some more tests.

  • mcdruid committed 670371cb on 7.x-2.x
    Issue #3406766 by mcdruid: Upgrade to use V3 of the HIBP API?
    
mcdruid’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.