Problem/Motivation

Follow up issue after
#3400246: Refactor updates for Varbase Media Hero Slider by moving hook updates to include/updates with load Include based on major branches

The \Drupal::moduleHandler()->loadInclude function operates slowly and necessitates the installation of the associated module to ensure proper formatting and logical functioning.

Proposed resolution

Change to

// Include all helpers and updates.
include_once __DIR__ . '/includes/helpers.inc';
include_once __DIR__ . '/includes/updates.inc';

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.17, varbase_heroslider_media-9.0.15, varbase-9.1.0, varbase_heroslider_media-9.1.1, varbase-10.0.0-rc1, varbase_heroslider_media-10.0.0-beta6

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3406025: Switched from Drupal module load Include to native PHP include once for Varbase Media Hero Slider to include all helpers and updates

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Title: Switch from Drupal module load Include to native PHP include once for TTTTTTTTTTT to include all helpers and updates » Switch from Drupal module load Include to native PHP include once for Varbase Media Hero Slider to include all helpers and updates

  • Rajab Natshah committed 465e093a on 9.0.x
    Issue #3406025: Switch from Drupal module load Include to native PHP...

  • Rajab Natshah committed fb5ebb21 on 9.1.x
    Issue #3406025: Switch from Drupal module load Include to native PHP...

  • Rajab Natshah committed 5e797047 on 9.0.x
    Issue #3406025: Switch from Drupal module load Include to native PHP...

  • Rajab Natshah committed f3d75100 on 10.0.x
    Issue #3406025: Switch from Drupal module load Include to native PHP...
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.17

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.0-rc1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.