Problem/Motivation

1) In some tests in function assertEquals(), assertSame() arguments type is miss ordered.

public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = FALSE, $ignoreCase = FALSE)
public static function assertSame($expected, $actual, string $message = '')

2) In some places assertCount() is better fit.

$this->assertEquals(1, count($mails));

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

zniki.ru created an issue. See original summary.

nikolay shapovalov’s picture

Title: Fix "Misordered 'assertEquals()' arguments" » Fix "Misordered 'assertEquals()', 'assertSame()' arguments"
Issue summary: View changes
Status: Active » Needs review

MR created, and ready for review.

ankithashetty made their first commit to this issue’s fork.

nikolay shapovalov’s picture

Issue summary: View changes

@andypost thanks for a review.
@AnkShetty thanks for updating MR.
I found some more places where assertCount() is a better fit, and make changes.
MR is ready for review.

berdir made their first commit to this issue’s fork.

berdir’s picture

Status: Needs review » Fixed

Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.