Problem/Motivation
1) In some tests in function assertEquals(), assertSame() arguments type is miss ordered.
public function assertEquals($expected, $actual, $delta = 0.0, $canonicalize = FALSE, $ignoreCase = FALSE)
public static function assertSame($expected, $actual, string $message = '')
2) In some places assertCount() is better fit.
$this->assertEquals(1, count($mails));
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork contact_storage-3403831
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
nikolay shapovalov commentedMR created, and ready for review.
Comment #5
nikolay shapovalov commented@andypost thanks for a review.
@AnkShetty thanks for updating MR.
I found some more places where assertCount() is a better fit, and make changes.
MR is ready for review.
Comment #8
berdirMerged.