Problem/Motivation
Steps to reproduce
Load a View in the administrative interface which has a Views Display that is disabled. When you are on the Views Display the main content is sort of greyed out and there's a small message indicating "This display is disabled" -- but if you are on a different Views Display there is no way of identifying which other(s) may be disabled. Current screenshot attached.
Proposed resolution
I propose to show a small icon in front of disabled Views Display links to indicate that they are disabled. I'll submit a MR following the pattern in this thread, for your consideration.
Remaining tasks
Add CSS changes.
User interface changes
Icon shows up in Views Display link if it is disabled.
API changes
None.
Data model changes
None.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | Screenshot at Nov 28 11-47-05.png | 291.91 KB | shweta__sharma |
| #5 | Screenshot at Nov 20 12-33-20.png | 418.66 KB | shweta__sharma |
| #4 | gin-drupal-views-display-disabled-after.png | 26.93 KB | laryn |
| #2 | gin-drupal-views-display-disabled-current.png | 39.56 KB | laryn |
Issue fork gin-3402619
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
larynComment #4
larynI've added a MR here, and I'm attaching a screenshot to compare to the original.
Comment #5
shweta__sharma commentedHi @laryn,
I have tested your MR !338 and it is cleanly applied. The disable icon is implemented correctly when any of the view displays is disabled in the view, but from my observation, we can give some more space from the right side to the icon.
Comment #6
larynI made an adjustment.
Comment #7
shweta__sharma commentedI have verified the MR and the changes have been successfully implemented as per the requirement. Attached screenshot for reference.
Thanks
Comment #8
shweta__sharma commentedComment #11
saschaeggiThanks @laryn for contributing this upstream 👏