Problem/Motivation

Steps to reproduce

Load a View in the administrative interface which has a Views Display that is disabled. When you are on the Views Display the main content is sort of greyed out and there's a small message indicating "This display is disabled" -- but if you are on a different Views Display there is no way of identifying which other(s) may be disabled. Current screenshot attached.

Proposed resolution

I propose to show a small icon in front of disabled Views Display links to indicate that they are disabled. I'll submit a MR following the pattern in this thread, for your consideration.

Remaining tasks

Add CSS changes.

User interface changes

Icon shows up in Views Display link if it is disabled.

API changes

None.

Data model changes

None.

Issue fork gin-3402619

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

laryn created an issue. See original summary.

laryn’s picture

Issue summary: View changes
StatusFileSize
new39.56 KB

laryn’s picture

Status: Active » Needs review
StatusFileSize
new26.93 KB

I've added a MR here, and I'm attaching a screenshot to compare to the original.

shweta__sharma’s picture

StatusFileSize
new418.66 KB

Hi @laryn,
I have tested your MR !338 and it is cleanly applied. The disable icon is implemented correctly when any of the view displays is disabled in the view, but from my observation, we can give some more space from the right side to the icon.

image

laryn’s picture

I made an adjustment.

shweta__sharma’s picture

StatusFileSize
new291.91 KB

I have verified the MR and the changes have been successfully implemented as per the requirement. Attached screenshot for reference.
Thanks

shweta__sharma’s picture

Status: Needs review » Reviewed & tested by the community

saschaeggi made their first commit to this issue’s fork.

  • saschaeggi committed 14d79760 on 8.x-3.x authored by laryn
    Issue #3402619: Visually indicate disabled Views Display.
    
saschaeggi’s picture

Status: Reviewed & tested by the community » Fixed

Thanks @laryn for contributing this upstream 👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.