Problem/Motivation

In rector/rector v0.18.7 there is no parameters() method for the class Rector\Config\RectorConfig.
By default the rector notices are added as comments.

Steps to reproduce

Proposed resolution

Update rector-config-template.php to remove the call and use of the parameters.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Issue fork upgrade_rector-3401571

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

somersoft created an issue. See original summary.

somersoft opened merge request !8

somersoft’s picture

somersoft commented
Status: Active » Needs review
gorkagr’s picture

gorkagr commented

Hi

I can confirm the patch works and I can run rector in a module or via CLI after the patch is applied.
Thnks!

  • f1d05f13 committed on 8.x-1.x 
    Issue #3401571 by somersoft, gorkagr: Removal of RectorConfig->...

  • 5985dab4 committed on 2.x 
    Issue #3401571 by somersoft, gorkagr: Removal of RectorConfig->...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Fixed

Thanks, I verified with https://github.com/palantirnet/drupal-rector/blob/main/rector.php that this is correct. I also removed the CSS portion of the MR :) Landed in 1.x first and cherry-picked to 2.x. Going to make the updated release once CI comes back green.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Removal of RectorConfig->parameters() » Removal of RectorConfig->parameters() to support current rector release
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Released in https://www.drupal.org/project/upgrade_rector/releases/2.0.0-alpha2 and https://www.drupal.org/project/upgrade_rector/releases/8.x-1.0-alpha10 Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Gábor Hojtsy closed merge request !8