Problem/Motivation
Having old hook updates back from ~8.0, ~9.0.0, and ~10.0.0 in the same location in the varbase_media_header.install file.
Which brings number of conflicting issues for order of hooks when committing, and updating a miner or batch fix release.
Having issues when updating an old version in the old branch, then the latest branch has to shift and have the old hook updates before.
To brevet issues when upgrading to a major release.
Proposed resolution
Keep all hook updates, but archive them.
not to remove any of them
- Add the
include/updatesfolder into the module. - Move hook updates to
include/updates/v8.inc,include/updates/v9.inc,include/updates/v10.inc - Add the
include/updates/all.incfile and add the following:
\Drupal::moduleHandler()->loadInclude('varbase_media_header', 'inc', 'include/updates/v8'); \Drupal::moduleHandler()->loadInclude('varbase_media_header', 'inc', 'include/updates/v9'); \Drupal::moduleHandler()->loadInclude('varbase_media_header', 'inc', 'include/updates/v10'); - Add the following to the
varbase_media_header.installfile
\Drupal::moduleHandler()->loadInclude('varbase_media_header', 'inc', 'include/updates/all');
Add more inc includes for more update files when needed.
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ UX/UI designer responsibilities
- ➖ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release varbase-9.0.17, varbase_media_header-9.0.7, varbase-10.0.0-rc1, varbase_media_header-10.0.0-beta1
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3400630: Refactored updates for Varbase Media Header by moving hook updates to
include/updateswith load Include based on major branches
Comments
Comment #4
rajab natshahComment #5
rajab natshah✅ Released varbase_media_header-9.0.7
Comment #6
rajab natshah✅ Released varbase_media_header-10.0.0-beta1
Comment #7
rajab natshahComment #9
rajab natshah✅ Released varbase-9.0.17
Comment #10
rajab natshah✅ Released varbase-10.0.0-rc1