Problem/Motivation

Having old hook updates back from ~8.0, ~9.0.0, and ~10.0.0 in the same location in the varbase_landing.install file.

Which brings number of conflicting issues for order of hooks when committing, and updating a miner or batch fix release.
Having issues when updating an old version in the old branch, then the latest branch has to shift and have the old hook updates before.
To prevent issues when upgrading to a major release.

Proposed resolution

Keep all hook updates, but archive them.
not to remove any of them

  • Add the include/updates folder into the module.
  • Move hook updates to include/updates/v8.inc, include/updates/v9.inc, include/updates/v10.inc
  • Add the include/updates/all.inc file and add the following:
            \Drupal::moduleHandler()->loadInclude('varbase_landing', 'inc', 'include/updates/v8');
            \Drupal::moduleHandler()->loadInclude('varbase_landing', 'inc', 'include/updates/v9');
            \Drupal::moduleHandler()->loadInclude('varbase_landing', 'inc', 'include/updates/v10');
        
  • Add the following to the varbase_landing.install file
    \Drupal::moduleHandler()->loadInclude('varbase_landing', 'inc', 'include/updates/all');

Add more inc includes for more update files when needed.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.17, varbase_landing-9.0.12, varbase-10.0.0-rc1, varbase_landing-10.0.0-rc1

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3400422: Refactored updates for Varbase Landing Page (Paragraphs) by moving hook updates to include/updates with load Include based on major branches

Comments

Rajab Natshah created an issue. See original summary.

  • Rajab Natshah committed d0e01438 on 10.0.x
    Issue #3400422: Refactor updates for Varbase Landing Page (Paragraphs)...

  • Rajab Natshah committed 7f152282 on 9.0.x
    Issue #3400422: Refactor updates for Varbase Landing Page (Paragraphs)...
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-9.0.17, +varbase_landing-9.0.12, +varbase-10.0.0-rc1, +varbase_landing-10.0.0-rc1
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.17

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.0-rc1