Issues reported by PHPStan

Problem/Motivation

Steps to reproduce

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ ---------------------------------------------------------------------- 
  Line   ldap_authentication/src/Controller/LoginValidatorBase.php             
 ------ ---------------------------------------------------------------------- 
  546    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------------ 
  Line   ldap_authorization/src/Plugin/authorization/Provider/LDAPAuthorizationProvider.php  
 ------ ------------------------------------------------------------------------------------ 
  238    \Drupal calls should be avoided in classes, use dependency injection                
         instead                                                                             
  246    \Drupal calls should be avoided in classes, use dependency injection                
         instead                                                                             
  261    \Drupal calls should be avoided in classes, use dependency injection                
         instead                                                                             
  278    \Drupal calls should be avoided in classes, use dependency injection                
         instead                                                                             
  315    \Drupal calls should be avoided in classes, use dependency injection                
         instead                                                                             
 ------ ------------------------------------------------------------------------------------ 
 ------ --------------------------------------------------------------------- 
  Line   ldap_authorization/tests/src/Unit/LdapAuthorizationProviderTest.php  
 ------ --------------------------------------------------------------------- 
  32     Call to deprecated method setMethods() of class                      
         PHPUnit\Framework\MockObject\MockBuilder:                            
         https://github.com/sebastianbergmann/phpunit/pull/3687               
 ------ --------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   ldap_query/src/Plugin/views/query/LdapQuery.php                       
 ------ ---------------------------------------------------------------------- 
  80     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  87     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  209    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  344    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ -------------------------------------------------------- 
  Line   ldap_query/tests/src/Unit/ViewsSortTest.php             
 ------ -------------------------------------------------------- 
  29     Call to deprecated method setMethodsExcept() of class   
         PHPUnit\Framework\MockObject\MockBuilder:               
         https://github.com/sebastianbergmann/phpunit/pull/3687  
 ------ -------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   ldap_servers/src/Form/ServerDeleteForm.php                            
 ------ ---------------------------------------------------------------------- 
  44     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   ldap_servers/src/Form/ServerEnableDisableForm.php                     
 ------ ---------------------------------------------------------------------- 
  72     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  78     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   ldap_servers/src/ServerListBuilder.php                                
 ------ ---------------------------------------------------------------------- 
  88     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ -------------------------------------------------------- 
  Line   ldap_servers/tests/src/Unit/TokenTest.php               
 ------ -------------------------------------------------------- 
  45     Call to deprecated method setMethods() of class         
         PHPUnit\Framework\MockObject\MockBuilder:               
         https://github.com/sebastianbergmann/phpunit/pull/3687  
 ------ -------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   ldap_user/src/Processor/DrupalUserProcessor.php                       
 ------ ---------------------------------------------------------------------- 
  250    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   ldap_user/src/Processor/GroupUserUpdateProcessor.php                  
 ------ ---------------------------------------------------------------------- 
  206    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 19 errors  

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes