Problem/Motivation

Group Authorization doesn't support the recommended versions of Group module, 2.0 and 3.0, blocking updating of Group module.

Steps to reproduce

Changing my composer.lock dependency to group 2.0, I was able to update to Group 2.0 to see how Group Authorization would fare, and got this error on the Group Authorization UI page:

Error: Call to undefined method Drupal\group\Entity\GroupRole::isInternal() in Drupal\authorization_group\Plugin\authorization\consumer\GroupConsumer->buildRowForm() (line 65 of modules/contrib/authorization_group/src/Plugin/authorization/Consumer/GroupConsumer.php).

Proposed resolution

Group Authorization needs a 2.0.0 version compatible with Group 2.0/3.0

Remaining tasks

User interface changes

API changes

Group API changes are documented here:
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib...

Data model changes

In the Group 2.0 release notes, roles have been completely reworked:
https://www.drupal.org/project/group/releases/2.0.0v

Issue fork authorization_group-3396972

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

willabby created an issue. See original summary.

bluegeek9 made their first commit to this issue’s fork.

bluegeek9’s picture

bluegeek9 commented
Assigned: Unassigned » bluegeek9
Priority: Major » Normal

bluegeek9 opened merge request !9

  • bluegeek9 committed 3e503cd4 on 8.x-1.x 
    Issue #3396972 by bluegeek9: New version for Group 2.0/3.0 compatability
bluegeek9’s picture

bluegeek9 commented

I thought it might be able to be done in a single version, but it looks like a 2.0.x branch needs to created for Group 2/3 support.

bluegeek9’s picture

bluegeek9 commented
Version: 8.x-1.0 » 2.0.x-dev

KarlShea made their first commit to this issue’s fork.

KarlShea opened merge request !10

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

Got 2.x at least installable with composer with Group 2.x or 3.x

KarlShea opened merge request !11

  • KarlShea committed b388d386 on 8.x-1.x 
    Revert "Resolve #3396972 "Group 2 3""

This reverts commit...
bluegeek9’s picture

bluegeek9 commented

To get the form working with Group 2/3 replace 

 if ($role->isInternal()) {

with

 if (!$role->getGlobalRoleId()) {
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

I hate gitlab so much.

This:

if (!$role->getGlobalRoleId()) {

Not this?

if (!$role->isOutsider()) {
karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

When I tried !$role->getGlobalRoleId() it's not populating any roles, where !$role->isOutsider() is listing non-global roles.

KarlShea opened merge request !12

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented

We might need a new issue to fix the issue fork

karlshea’s picture

karlshea
he/him
Primary language English
Location Minneapolis 🇺🇸
commented
Status: Active » Closed (outdated)

Closing in lieu of #3396972 so issue fork points to 2.0.x

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned