Fix the issues reported by phpcs [#3395565]

There are various code style issues which need fixing

phpcs         > FILE: ..._entities_test/src/Controller/ExternalEntitiesJsonController.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >  33 | WARNING | [x] A comma should follow the last multiline array
phpcs         >     |         |     item. Found:
phpcs         >     |         |     '2596b1ba-43bb-4440-9f0c-f1974f733311'
phpcs         >     |         |     (Drupal.Arrays.Array.CommaLastItem)
phpcs         >  58 | ERROR   | [ ] Missing @var tag in member variable comment
phpcs         >     |         |     (Drupal.Commenting.VariableComment.MissingVar)
phpcs         >  59 | ERROR   | [ ] Class property $reference_data should use
phpcs         >     |         |     lowerCamel naming without underscores
phpcs         >     |         |     (Drupal.NamingConventions.ValidVariableName.LowerCamelName)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...sts/modules/external_entities_test/external_entities_test.module
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  6 | ERROR | [x] Expected 1 newline at end of file; 2 found
phpcs         >    |       |     (Drupal.Files.EndFileNewline.TooMany)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...368304/src/FieldMapper/ConfigurableExpressionFieldMapperBase.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  161 | ERROR | [x] Each PHP statement must be on a line by itself
phpcs         >      |       |     (Generic.Formatting.DisallowMultipleStatements.SameLine)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...l_entities-3368304/src/FieldMapper/ExpressionFieldMapperBase.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >    6 | ERROR   | [x] Use statements should be sorted alphabetically.
phpcs         >      |         |     The first wrong one is
phpcs         >      |         |     Drupal\Core\Datetime\DrupalDateTime.
phpcs         >      |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
phpcs         >  176 | ERROR   | [x] Functions must not contain multiple empty lines
phpcs         >      |         |     in a row; found 2 empty lines
phpcs         >      |         |     (Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines)
phpcs         >  217 | WARNING | [x] A comma should follow the last multiline array
phpcs         >      |         |     item. Found: ]
phpcs         >      |         |     (Drupal.Arrays.Array.CommaLastItem)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...om/external_entities-3368304/src/FieldMapper/FieldMapperBase.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  92 | ERROR | [x] Use null coalesce operator instead of ternary
phpcs         >     |       |     operator.
phpcs         >     |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...ternal_entities-3368304/src/Routing/ExternalEntityTypeRoutes.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  31 | ERROR | Parameter $module_handler is not described in
phpcs         >     |       | comment
phpcs         >     |       | (Drupal.Commenting.FunctionComment.ParamMissingDefinition)
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...s/custom/external_entities-3368304/src/Entity/ExternalEntity.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >   80 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  232 | ERROR   | [x] @inheritDoc found. Did you mean
phpcs         >      |         |     {@inheritDoc}?
phpcs         >      |         |     (Drupal.Commenting.DocComment.InheritDocWithoutBraces)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...xternal_entities-3368304/src/Entity/Query/External/Condition.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  24 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >     |         |     delimiters
phpcs         >     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...stom/external_entities-3368304/src/Entity/ExternalEntityType.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  97 | WARNING | Line exceeds 80 characters; contains 84
phpcs         >     |         | characters (Drupal.Files.LineLength.TooLong)
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...om/external_entities-3368304/src/Form/ExternalEntityTypeForm.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >  670 | ERROR   | [ ] The array declaration extends to column 121 (the
phpcs         >      |         |     limit is 120). The array content should be split
phpcs         >      |         |     up over multiple lines
phpcs         >      |         |     (Drupal.Arrays.Array.LongLineDeclaration)
phpcs         >  683 | ERROR   | [ ] The array declaration extends to column 122 (the
phpcs         >      |         |     limit is 120). The array content should be split
phpcs         >      |         |     up over multiple lines
phpcs         >      |         |     (Drupal.Arrays.Array.LongLineDeclaration)
phpcs         >  691 | ERROR   | [ ] The array declaration extends to column 121 (the
phpcs         >      |         |     limit is 120). The array content should be split
phpcs         >      |         |     up over multiple lines
phpcs         >      |         |     (Drupal.Arrays.Array.LongLineDeclaration)
phpcs         >  761 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  791 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ..._entities-3368304/src/ResponseDecoder/ResponseDecoderFactory.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  29 | ERROR | [x] Use null coalesce operator instead of ternary
phpcs         >     |       |     operator.
phpcs         >     |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...om/external_entities-3368304/src/ExternalEntityTypeInterface.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  5 | WARNING | [x] Unused use statement
phpcs         >    |         |     (Drupal.Classes.UnusedUseStatement.UnusedUse)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...es-3368304/src/StorageClient/ExternalEntityStorageClientBase.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  91 | ERROR | [x] Use null coalesce operator instead of ternary
phpcs         >     |       |     operator.
phpcs         >     |       |     (SlevomatCodingStandard.ControlStructures.RequireNullCoalesceOperator.NullCoalesceOperatorNotUsed)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...s/custom/external_entities-3368304/src/ExternalEntityStorage.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 3 ERRORS AND 3 WARNINGS AFFECTING 6 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >  189 | ERROR   | [x] Data types in @throws tags need to be fully
phpcs         >      |         |     namespaced
phpcs         >      |         |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
phpcs         >  204 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  237 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  333 | ERROR   | [x] Expected newline after closing brace
phpcs         >      |         |     (Drupal.ControlStructures.ControlSignature.NewlineAfterCloseBrace)
phpcs         >  373 | ERROR   | [x] Data types in @throws tags need to be fully
phpcs         >      |         |     namespaced
phpcs         >      |         |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
phpcs         >  386 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...entities-3368304/src/Event/ExternalEntityExtractRawDataEvent.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 1 ERROR AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  6 | ERROR | [x] Use statements should be sorted alphabetically. The
phpcs         >    |       |     first wrong one is
phpcs         >    |       |     Drupal\external_entities\ExternalEntityInterface.
phpcs         >    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...04/src/Plugin/ExternalEntities/FieldMapper/SimpleFieldMapper.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 27 ERRORS AND 1 WARNING AFFECTING 28 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >    8 | WARNING | [x] Unused use statement
phpcs         >      |         |     (Drupal.Classes.UnusedUseStatement.UnusedUse)
phpcs         >   13 | ERROR   | [ ] Doc comment short description must be on a
phpcs         >      |         |     single line, further text should be a separate
phpcs         >      |         |     paragraph
phpcs         >      |         |     (Drupal.Commenting.DocComment.ShortSingleLine)
phpcs         >  101 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$raw_data"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  102 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$context"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  124 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$field_values"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  125 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$raw_data"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  126 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$context"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  165 | ERROR   | [ ] Doc comment short description must be on a
phpcs         >      |         |     single line, further text should be a separate
phpcs         >      |         |     paragraph
phpcs         >      |         |     (Drupal.Commenting.DocComment.ShortSingleLine)
phpcs         >  173 | ERROR   | [x] Data types in @param tags need to be fully
phpcs         >      |         |     namespaced
phpcs         >      |         |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
phpcs         >  183 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$raw_data"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  184 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$remaining_mapping_keys"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  185 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$seen_mapping_keys"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  187 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$field_delta"; 22 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  188 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$field_property_name"; 19 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  201 | ERROR   | [x] Inline comments must end in full-stops,
phpcs         >      |         |     exclamation marks, question marks, colons, or
phpcs         >      |         |     closing parentheses
phpcs         >      |         |     (Drupal.Commenting.InlineComment.InvalidEndChar)
phpcs         >  211 | ERROR   | [x] Inline comments must end in full-stops,
phpcs         >      |         |     exclamation marks, question marks, colons, or
phpcs         >      |         |     closing parentheses
phpcs         >      |         |     (Drupal.Commenting.InlineComment.InvalidEndChar)
phpcs         >  230 | ERROR   | [ ] Doc comment short description must be on a
phpcs         >      |         |     single line, further text should be a separate
phpcs         >      |         |     paragraph
phpcs         >      |         |     (Drupal.Commenting.DocComment.ShortSingleLine)
phpcs         >  237 | ERROR   | [x] Data types in @param tags need to be fully
phpcs         >      |         |     namespaced
phpcs         >      |         |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
phpcs         >  247 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$raw_data"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  248 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$raw_keys"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  250 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$field_delta"; 22 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  251 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$field_property_name"; 19 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  258 | ERROR   | [ ] Doc comment short description must be on a
phpcs         >      |         |     single line, further text should be a separate
phpcs         >      |         |     paragraph
phpcs         >      |         |     (Drupal.Commenting.DocComment.ShortSingleLine)
phpcs         >  266 | ERROR   | [x] Data types in @param tags need to be fully
phpcs         >      |         |     namespaced
phpcs         >      |         |     (Drupal.Commenting.DataTypeNamespace.DataTypeNamespace)
phpcs         >  271 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$raw_data"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  272 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$remaining_mapping_keys"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  273 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$seen_mapping_keys"; 20 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         >  275 | ERROR   | [x] Expected 1 space between type hint and argument
phpcs         >      |         |     "$field_property_name"; 19 found
phpcs         >      |         |     (Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingAfterHint)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...ities-3368304/src/Plugin/ExternalEntities/StorageClient/Rest.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >  373 | WARNING | [x] 'TODO: Apply parameter operator.' should match
phpcs         >      |         |     the format '@todo Fix problem X here.'
phpcs         >      |         |     (Drupal.Commenting.TodoComment.TodoFormat)
phpcs         >  434 | WARNING | [x] 'TODO: Apply parameter operator.' should match
phpcs         >      |         |     the format '@todo Fix problem X here.'
phpcs         >      |         |     (Drupal.Commenting.TodoComment.TodoFormat)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...tities-3368304/src/Plugin/Field/AnnotationTitleFieldItemList.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >  26 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >     |         |     delimiters
phpcs         >     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  31 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >     |         |     delimiters
phpcs         >     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: .../external_entities-3368304/src/ExternalEntityTypeListBuilder.php
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
phpcs         > ----------------------------------------------------------------------
phpcs         >  40 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >     |         |     delimiters
phpcs         >     |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > FILE: ...odules/custom/external_entities-3368304/external_entities.module
phpcs         > ----------------------------------------------------------------------
phpcs         > FOUND 7 ERRORS AND 9 WARNINGS AFFECTING 15 LINES
phpcs         > ----------------------------------------------------------------------
phpcs         >   20 | ERROR   | [x] Use statements should be sorted alphabetically.
phpcs         >      |         |     The first wrong one is
phpcs         >      |         |     Drupal\Core\Render\Element.
phpcs         >      |         |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
phpcs         >   51 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >   90 | WARNING | [ ] Only string literals should be passed to t()
phpcs         >      |         |     where possible
phpcs         >      |         |     (Drupal.Semantics.FunctionT.NotLiteralString)
phpcs         >   91 | WARNING | [ ] Only string literals should be passed to t()
phpcs         >      |         |     where possible
phpcs         >      |         |     (Drupal.Semantics.FunctionT.NotLiteralString)
phpcs         >   92 | WARNING | [ ] Only string literals should be passed to t()
phpcs         >      |         |     where possible
phpcs         >      |         |     (Drupal.Semantics.FunctionT.NotLiteralString)
phpcs         >  129 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  203 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  240 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  374 | ERROR   | [x] Expected 1 space(s) before asterisk; 3 found
phpcs         >      |         |     (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
phpcs         >  375 | ERROR   | [x] Expected 1 space(s) before asterisk; 3 found
phpcs         >      |         |     (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
phpcs         >  376 | ERROR   | [x] Expected 1 space(s) before asterisk; 3 found
phpcs         >      |         |     (Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar)
phpcs         >  378 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
phpcs         >      |         |     found 1 spaces
phpcs         >      |         |     (Drupal.Commenting.FunctionComment.ParamCommentIndentation)
phpcs         >  379 | ERROR   | [x] Parameter comment indentation must be 3 spaces,
phpcs         >      |         |     found 1 spaces
phpcs         >      |         |     (Drupal.Commenting.FunctionComment.ParamCommentIndentation)
phpcs         >  379 | ERROR   | [x] Parameter comment must end with a full stop
phpcs         >      |         |     (Drupal.Commenting.FunctionComment.ParamCommentFullStop)
phpcs         >  391 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         >  404 | WARNING | [x] Inline @var declarations should use the /** */
phpcs         >      |         |     delimiters
phpcs         >      |         |     (Drupal.Commenting.InlineVariableComment.VarInline)
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > Time: 2.13 secs; Memory: 8MB
phpcs         > 
phpcs         > 
phpcs         > PHP CODE SNIFFER REPORT SUMMARY
phpcs         > ----------------------------------------------------------------------
phpcs         > FILE                                                  ERRORS  WARNINGS
phpcs         > ----------------------------------------------------------------------
phpcs         > ...xternal_entities-3368304/external_entities.module  7       9
phpcs         > ...al_entities-3368304/src/ExternalEntityStorage.php  3       3
phpcs         > ...ities-3368304/src/ExternalEntityTypeInterface.php  0       1
phpcs         > ...ies-3368304/src/ExternalEntityTypeListBuilder.php  0       1
phpcs         > ...al_entities-3368304/src/Entity/ExternalEntity.php  1       1
phpcs         > ...ntities-3368304/src/Entity/ExternalEntityType.php  0       1
phpcs         > ...s-3368304/src/Entity/Query/External/Condition.php  0       1
phpcs         > ...4/src/Event/ExternalEntityExtractRawDataEvent.php  1       0
phpcs         > ...dMapper/ConfigurableExpressionFieldMapperBase.php  1       0
phpcs         > ...304/src/FieldMapper/ExpressionFieldMapperBase.php  2       1
phpcs         > ...ities-3368304/src/FieldMapper/FieldMapperBase.php  1       0
phpcs         > ...ities-3368304/src/Form/ExternalEntityTypeForm.php  3       2
phpcs         > ...xternalEntities/FieldMapper/SimpleFieldMapper.php  27      1
phpcs         > ...rc/Plugin/ExternalEntities/StorageClient/Rest.php  0       2
phpcs         > ...src/Plugin/Field/AnnotationTitleFieldItemList.php  0       2
phpcs         > ...04/src/ResponseDecoder/ResponseDecoderFactory.php  1       0
phpcs         > ...-3368304/src/Routing/ExternalEntityTypeRoutes.php  1       0
phpcs         > ...StorageClient/ExternalEntityStorageClientBase.php  1       0
phpcs         > ...ernal_entities_test/external_entities_test.module  1       0
phpcs         > ...src/Controller/ExternalEntitiesJsonController.php  2       1
phpcs         > ----------------------------------------------------------------------
phpcs         > A TOTAL OF 52 ERRORS AND 26 WARNINGS WERE FOUND IN 54 FILES
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX 64 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
phpcs         > ----------------------------------------------------------------------
phpcs         > 
phpcs         > 
phpcs         > PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
phpcs         > ----------------------------------------------------------------------
phpcs         >     SOURCE                                                       COUNT
phpcs         > ----------------------------------------------------------------------
phpcs         > [x] Squiz.Functions.FunctionDeclarationArgumentSpacing.SpacingA  18
phpcs         > [x] Drupal.Commenting.InlineVariableComment.VarInline            16
phpcs         > [x] Drupal.Commenting.DataTypeNamespace.DataTypeNamespace        5
phpcs         > [ ] Drupal.Commenting.DocComment.ShortSingleLine                 4
phpcs         > [ ] Drupal.Arrays.Array.LongLineDeclaration                      3
phpcs         > [x] Drupal.Commenting.DocCommentAlignment.SpaceBeforeStar        3
phpcs         > [ ] Drupal.Semantics.FunctionT.NotLiteralString                  3
phpcs         > [x] SlevomatCodingStandard.ControlStructures.RequireNullCoalesc  3
phpcs         > [x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.  3
phpcs         > [x] Drupal.Arrays.Array.CommaLastItem                            2
phpcs         > [x] Drupal.Classes.UnusedUseStatement.UnusedUse                  2
phpcs         > [x] Drupal.Commenting.FunctionComment.ParamCommentIndentation    2
phpcs         > [x] Drupal.Commenting.InlineComment.InvalidEndChar               2
phpcs         > [x] Drupal.Commenting.TodoComment.TodoFormat                     2
phpcs         > [x] Drupal.Commenting.DocComment.InheritDocWithoutBraces         1
phpcs         > [x] Drupal.Commenting.FunctionComment.ParamCommentFullStop       1
phpcs         > [ ] Drupal.Commenting.FunctionComment.ParamMissingDefinition     1
phpcs         > [ ] Drupal.Commenting.VariableComment.MissingVar                 1
phpcs         > [x] Drupal.ControlStructures.ControlSignature.NewlineAfterClose  1
phpcs         > [x] Drupal.Files.EndFileNewline.TooMany                          1
phpcs         > [ ] Drupal.Files.LineLength.TooLong                              1
phpcs         > [ ] Drupal.NamingConventions.ValidVariableName.LowerCamelName    1
phpcs         > [x] Generic.Formatting.DisallowMultipleStatements.SameLine       1
phpcs         > [x] Squiz.WhiteSpace.SuperfluousWhitespace.EmptyLines            1
phpcs         > ----------------------------------------------------------------------
phpcs         > A TOTAL OF 78 SNIFF VIOLATIONS WERE FOUND IN 24 SOURCES
phpcs         > ----------------------------------------------------------------------
phpcs         > PHPCBF CAN FIX THE 17 MARKED SOURCES AUTOMATICALLY (64 VIOLATIONS IN TOTAL)
phpcs         > ----------------------------------------------------------------------

Steps to reproduce

Run following command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml external_entities/

Comment	File	Size	Author
#25	3395565-revert_high_risk_phpcs_changes.patch	19.71 KB	joseph.olstad
#22	3395565-revert_phpcs_changes_this_time.patch	44.81 KB	joseph.olstad
#21	3395565-revert_phpcs_changes.patch	45.66 KB	joseph.olstad
#21	3395565-no_change.patch	320 bytes	joseph.olstad
#5	Screenshot from 2023-10-26 13-43-23.png	144.43 KB	chetan 11
#15	succes-patch.png	17.93 KB	zkhan.aamir

Issue fork external_entities-3395565

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3395565-fix-code-style changes, plain diff MR !30 / changes, plain diff MR !26
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

20 October 2023 at 10:55

pefferen created an issue. See original summary.

Comment #2

chetan 11 commented 20 October 2023 at 11:38

Assigned:

Unassigned

» chetan 11

Comment #3

pefferen commented 25 October 2023 at 14:44

@chetan 11 can you push your progress, I would like to get this issue moving

Comment #4

26 October 2023 at 08:10

chetan 11 opened merge request !26

Comment #5

chetan 11 commented 26 October 2023 at 08:13

Status:

Active

» Needs review

Status	File	Size
new	Screenshot from 2023-10-26 13-43-23.png	144.43 KB

HI @pefferen,
I have fixed all the phpcs issue in the above module, please check raised MR,
Thanks.

Comment #6

pefferen commented 26 October 2023 at 11:54

Status:

Needs review

» Needs work

nice work @chetan 11, the test are failing. in one instance because the definition of the constant has changed, the define function can be replaced with const in this case, only not as a class inside a module file. We can also move the constant to ExternalEntityInterface and refactor the usage.

 /**
  * Property indicating if the annotated external entity should not be saved.
@@ -37,7 +37,10 @@ use Drupal\Core\Render\Element;
  *
  * @internal
  */
-define('EXTERNAL_ENTITIES_BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE_PROPERTY', 'BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE');
+class ExternalEntitiesConstants {
+  const BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE_PROPERTY = 'BYPASS_ANNOTATED_EXTERNAL_ENTITY_SAVE';
+
+}

Comment #7

zkhan.aamir commented 19 December 2023 at 13:14

Title:	Fix code style issues	» Fix the issues reported by phpcs
Issue summary:	View changes
Issue tags:		+Coding standards

Issue summary updated

Comment #8

26 December 2023 at 15:42

Shank115 made their first commit to this issue’s fork.

Comment #9

zkhan.aamir commented 27 December 2023 at 07:26

Assigned:	chetan 11	» Unassigned
Status:	Needs work	» Needs review

Comment #10

paraderojether commented 3 January 2024 at 00:34

Status:

Needs review

» Needs work

I reviewed MR!26, applied against External Entities 8.x-2.x-dev with Drupal core version 10.1.7 and there are still phpcs errors and warnings shown below:

FILE: /Users/jetherparadero/Distributions/drupalorgissues/web/modules/contrib/external_entities/src/ExternalEntityAccessControlHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 42 ERRORS AND 1 WARNING AFFECTING 41 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  20 | ERROR   | [x] Opening brace should be on the same line as the declaration
  37 | ERROR   | [x] Opening brace should be on the same line as the declaration
  38 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  39 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  46 | ERROR   | [x] Opening brace should be on the same line as the declaration
  47 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  57 | ERROR   | [x] Opening brace should be on the same line as the declaration
  58 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  60 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  61 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  62 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  63 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
  66 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  66 | ERROR   | [x] Expected newline after closing brace
  67 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
  68 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  69 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  71 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  77 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  78 | ERROR   | [x] Opening brace should be on the same line as the declaration
  79 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  80 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  81 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
  84 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  86 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  92 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
  93 | ERROR   | [x] Opening brace should be on the same line as the declaration
  94 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  96 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  97 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  98 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 100 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 101 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 102 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 103 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 14
 106 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 10
 107 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 109 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 119 | ERROR   | [x] Opening brace should be on the same line as the declaration
 120 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 6
 124 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 42 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

I also found warning: 1 line adds whitespace errors. after applying the MR.

Kindly check and advise, please.
Thank you.

Comment #11

3 January 2024 at 04:55

Venkatraman Ganesan made their first commit to this issue’s fork.

Comment #12

nitin_lama

he/him

India

commented 3 January 2024 at 07:26

Assigned:

Unassigned

» nitin_lama

Comment #13

nitin_lama

he/him

India

commented 3 January 2024 at 07:27

Status:

Needs work

» Needs review

Fixed remaining phpcs issues. Please review.

Comment #14

nitin_lama

he/him

India

commented 3 January 2024 at 07:28

Assigned:

nitin_lama

» Unassigned

Comment #15

zkhan.aamir commented 9 January 2024 at 11:45

Status	File	Size
new	succes-patch.png	17.93 KB

All the error have been fixed.
Please refer the screenshot.

Comment #16

pefferen commented 9 January 2024 at 12:00

Status:

Needs review

» Reviewed & tested by the community

Comment #17

pefferen commented 9 January 2024 at 12:26

~~committed to dev~~

Comment #18

pefferen commented 9 January 2024 at 13:00

Status:

Reviewed & tested by the community

» Fixed

Comment #19

9 January 2024 at 14:33

pefferen committed dd0c7d9a on 8.x-2.x authored by chetan 11

Issue #3395565 by chetan 11, pefferen, nitin_lama, Shank115, Venkatraman...

Comment #20

pefferen commented 9 January 2024 at 14:33

committed to dev

Comment #21

joseph.olstad

French

commented 21 January 2024 at 17:39

Status:

Fixed

» Needs work

Status	File	Size
new	3395565-no_change.patch	320 bytes
new	3395565-revert_phpcs_changes.patch	45.66 KB

I suspect this latest commit broke the module. See automated test results.

Comment #22

joseph.olstad

French

commented 21 January 2024 at 17:44

Status	File	Size
new	3395565-revert_phpcs_changes_this_time.patch	44.81 KB

oops , this is the actual revert patch I was intending on uploading in the previous comment.

Comment #23

joseph.olstad

French

commented 21 January 2024 at 17:45

1 file was hidden/shown/deleted

Status	File	Size
hidden	3395565-revert_phpcs_changes.patch	45.66 KB

Comment #24

joseph.olstad

French

commented 21 January 2024 at 18:03

The revert patch in #22 is definitely fixing the regression.
Compare the no-change results (4 failures) with the revert patch in #22 that has 100% pass no fails.

Comment #25

joseph.olstad

French

commented 21 January 2024 at 18:51

Status	File	Size
new	3395565-revert_high_risk_phpcs_changes.patch	19.71 KB

Comment #26

joseph.olstad

French

commented 21 January 2024 at 19:10

1 file was hidden/shown/deleted

Status	File	Size
hidden	3395565-revert_phpcs_changes_this_time.patch	44.81 KB

Comment #27

21 January 2024 at 19:19

joseph.olstad opened merge request !30

Comment #28

joseph.olstad

French

commented 21 January 2024 at 19:27

Status:

Needs work

» Reviewed & tested by the community

Please merge MR 30 to fix the regressions.

OR, commit patch 25.

Proven that the previous changes broke the module , see test results in the no_change patch #21

Patch #25 passes automated tests as before.

See screenshot showing the date and time the previously committed change caused regressions:

phpcs changes caused regression

Comment #29

joseph.olstad

French

commented 22 January 2024 at 01:08

Status:

Reviewed & tested by the community

» Needs review

Comment #30

pefferen commented 22 January 2024 at 08:58

Thanks for your work @joseph, was intending to continue to work on the commits but some thing came up, I will check your new work soon

Comment #31

27 January 2024 at 09:46

pefferen committed 980c5c40 on 8.x-2.x authored by joseph.olstad

Issue #3395565 by pefferen, chetan 11, nitin_lama, Shank115, Venkatraman...

Comment #32

pefferen commented 27 January 2024 at 10:10

Status:

Needs review

» Fixed

thanks all for your effort, merged the issue

Comment #33

pefferen commented 27 January 2024 at 10:11

Status:

Fixed

» Closed (fixed)

Comment #34

joseph.olstad

French

commented 29 January 2024 at 15:48

Thank you @pefferen

Fix the issues reported by phpcs

Steps to reproduce

Issue fork external_entities-3395565

Comments

Referenced by