Problem/Motivation

isMasterRequest method no longer exist : https://www.drupal.org/node/3212750
Using it breaks website.

Steps to reproduce

Update to D10 and open website

Proposed resolution

Use isMainRequest() instead

CommentFileSizeAuthor
#5 domain_google_analytics-MasterRequest-3395092.patch559 bytesrdworianyn

Issue fork domain_google_analytics-3395092

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pasan.gamage created an issue. See original summary.

shreya_th’s picture

shreya_th commented
Assigned: Unassigned » shreya_th

Shreya_th opened merge request !7

shreya_th’s picture

shreya_th commented
Assigned: shreya_th » Unassigned
Status: Active » Needs review

Hi @pasan.gamage,
I have fixed this issue by changing isMasterRequest() to isMainRequest().Also created MR for this issue . kindly review the changes .

Thank you!

rdworianyn’s picture

rdworianyn commented
StatusFileSize
new domain_google_analytics-MasterRequest-3395092.patch559 bytes

Created patch for issue so this can be applied via composer.

davidiio’s picture

davidiio commented

Patch applied and no more errors on drupal 10.1.8
Thanks

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Version: 8.x-2.x-dev » 3.0.x-dev

Created a 3.0.x-dev release for D10/Symfony 6 compatibility.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs review » Reviewed & tested by the community

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Reviewed & tested by the community » Fixed

Fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.