Hook_menu is deprecated and should be replaced with routing

Issue fork commerce_liqpay-3393321

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ReINFaTe created an issue. See original summary.

ReINFaTe opened merge request !3

reinfate’s picture

reinfate commented

It turns out routing is not needed
API notify from Liqpay is handled in \Drupal\commerce_liqpay\Plugin\Commerce\PaymentGateway\Liqpayment::onNotify
And Return page is handled in \Drupal\commerce_liqpay\Plugin\Commerce\PaymentGateway\Liqpayment::onReturn

Therefore I've just removed hook_menu.

reinfate’s picture

reinfate commented
Status: Active » Needs review

bohart made their first commit to this issue’s fork.

  • bohart committed 557a3ebc on 2.0.x authored by ReINFaTe 
    Issue #3393321 by ReINFaTe, bohart: Removed hook_menu (replaced with...
bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Title: Replace commerce_liqpay_menu with routing » Remove hook_menu (PaymentGateway::onNotify method is using now)
Status: Needs review » Fixed

Committed to 2.0.x branch.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.