Problem/Motivation

Because the library eu_cookie_compliance is loaded on the preprocess hook, it loads also on de administration theme, and eu_cookie_compliance in most cases is not loaded.

Error Drupal.eu_cookie_compliance not defined

Proposed resolution

Check that Drupal.eu_cookie_compliance is defined

CommentFileSizeAuthor
eu_cookie_compliance.png52.45 KBeduardo morales alberti

Issue fork youtube_cookies-3390431

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Eduardo Morales Alberti created an issue. See original summary.

Eduardo Morales Alberti opened merge request !25

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Active » Needs review

Ready to review

omarlopesino’s picture

omarlopesino
he/him
commented

I think the definitive solution would be not loading the library when eu cookie compliance is not loaded, but that implies a bigger refactor and thinking about the rest of integrations like onetrust. So for the moment, this solution is valid enough.

Reviewing.

omarlopesino’s picture

omarlopesino
he/him
commented
Status: Needs review » Needs work

The solution is good, please review the requested changes. Thanks!

eduardo morales alberti’s picture

eduardo morales alberti
Primary language Spanish
Location Spain, 🇪🇺
commented
Status: Needs work » Needs review

omarlopesino’s picture

omarlopesino
he/him
commented
Status: Needs review » Fixed

Thank you! Merged at 2.0.x and created a 2.0.1 release with this bugfix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.