Problem/Motivation

Since the beginning of PHPStan usage in core CI, APC was turned off during the scan.

That was because
# Turn off apc to avoid corrupt composer cache.

Proposed resolution

Wonder if that is still needed now that PHPStan has its own separate job in the pipeline.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#10 3390212-10.patch702 bytesgauravvvv

Issue fork drupal-3390212

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mondrake created an issue. See original summary.

mondrake opened merge request !4891

mondrake’s picture

mondrake
Location 🇮🇹
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Pipeline is all green so doesn't seem to have caused any issues!

  • catch committed 27741bd1 on 11.x 
    Issue #3390212 by mondrake: [GitlabCI] stop turning off APC when running...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.1.x-dev

Committed/pushed to 11.x, thanks!

Doesn't apply to 10.1.x, are we missing a backport elsewhere?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

#3387339: Integrate codequality reports into Gitlab did not get backported but it adds a new dependency so we can't really do that in a patch release. Maybe we can backport the parts that don't add the dependency and install it manually still.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Reviewed & tested by the community » Patch (to be ported)

In the meantime we could just backport this separately to 10.1.x.

mondrake closed merge request !4891

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3390212-10.patch702 bytes

I have attached patch for 10.1.x

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Patch (to be ported) » Reviewed & tested by the community

Thanks!

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 10.1.x, thanks!

  • catch committed 53bb707c on 10.1.x 
    Issue #3390212 by mondrake, Gauravvvv, longwave, catch: [GitlabCI] stop...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.