Problem/Motivation

Padding and margin on top in 'New' tag in new comment added seems very less.

Steps to reproduce

Add a new comment in any content and check the yellow 'New' tag on top of comment.

Proposed resolution

Add padding to the tag and margin to its top.

CommentFileSizeAuthor
#3 after_patch.png16.9 KBtanuja bohra
#3 before_patch.png16.29 KBtanuja bohra
#2 3390115-before-patch.png106.24 KBswatidhurandhar
#2 3390115-after-patch.png129.74 KBswatidhurandhar
#2 acquia-claro-comment-tag-3390115-2.patch1.16 KBswatidhurandhar
Screenshot 2023-09-27 at 4.51.50 PM.png106.24 KBswatidhurandhar

Issue fork acquia_claro-3390115

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

swatidhurandhar created an issue. See original summary.

swatidhurandhar’s picture

swatidhurandhar commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new acquia-claro-comment-tag-3390115-2.patch1.16 KB
new 3390115-after-patch.png129.74 KB
new 3390115-before-patch.png106.24 KB

I have added a patch to fix the issue. Please review.

tanuja bohra’s picture

tanuja bohra commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before_patch.png16.29 KB
new after_patch.png16.9 KB

Verified the #2 patch on 9.5.x, the padding/margin for the "new" tag is added. Added screenshots for reference, RTBC++

vishalkhode’s picture

vishalkhode commented

Thanks for working on this. Changes looks good. Submit an MR, so this can be merged.

Rajeshreeputra made their first commit to this issue’s fork.

Rajeshreeputra opened merge request !8

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Assigned: Unassigned » vishalkhode

@vishalkhode MR is created, please take a look.

vishalkhode’s picture

vishalkhode commented
Assigned: vishalkhode » Unassigned
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.