Problem/Motivation

We started to get these errors.

Deprecated function: explode(): Passing null to parameter #2 ($string) of type string is deprecated in varbase_bootstrap_paragraphs_field_widget_entity_reference_paragraphs_form_alter() (line 135 of modules/contrib/varbase_bootstrap_paragraphs/varbase_bootstrap_paragraphs.module).

Warning: Undefined array key 1 in varbase_bootstrap_paragraphs_field_widget_entity_reference_paragraphs_form_alter() (line 138 of modules/contrib/varbase_bootstrap_paragraphs/varbase_bootstrap_paragraphs.module).

Running:
- Drupal 9.5.10
- Varbase bootstrap paragraphs 9.0.12

Proposed resolution

  • Add a check on the background colors

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release varbase-9.0.17, varbase_bootstrap_paragraphs-9.0.17, varbase_bootstrap_paragraphs-9.1.1, varbase-10.0.0-rc1, varbase_bootstrap_paragraphs-10.0.0-rc2

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

Comments

jedgar1mx created an issue. See original summary.

jedgar1mx’s picture

StatusFileSize
new63.42 KB
new47.46 KB

I noticed that the background selection for "no background" is not saving correctly. Probably the reason it returns the null warning.

shreya_th’s picture

Assigned: Unassigned » shreya_th
shreya_th’s picture

I have fixed the issues for background color returns null . Kindly review the above attached patch file.

shreya_th’s picture

Assigned: shreya_th » Unassigned
rajab natshah’s picture

Issue summary: View changes
Status: Active » Needs review

Thanks, Edgar for reporting.
Thank you, Shreya, for patching.
Reviewing and testing the fix

rajab natshah’s picture

Issue tags: +PHP 8.1, +PHP 8.2
rajab natshah’s picture

Assigned: Unassigned » rajab natshah
Issue summary: View changes
jedgar1mx’s picture

I don't see the error anymore but the form view still doesn't show the no background as selected.

rajab natshah’s picture

Title: Background color returns null » Fix null returns for Background colors
rajab natshah’s picture

Version: 9.0.12 » 9.1.x-dev
rajab natshah’s picture

Version: 9.1.x-dev » 9.0.x-dev
rajab natshah’s picture

Title: Fix null returns for Background colors » Fix null returns for Background colors with columns
Version: 9.0.x-dev » 9.1.x-dev
Status: Needs review » Active

Facing two issues with Background Colors:

  • 9.1.x-dev ( the colors are NOT showing up with Drupal ~10.1.0 at the back-end ) under Varbase 9.0.16

and

  • 10.0.x-dev ( showing at the back-end- but not showing bg colors for columns at the front-end ) under Varbase 10.0.x-dev

  • Rajab Natshah committed 5c35fe6b on 9.1.x
    Issue #3387135: Fix null returns for Background colors with columns
    

  • Rajab Natshah committed e1795937 on 9.0.x
    Issue #3387135: Fix null returns for Background colors with columns
    

  • Rajab Natshah committed a0902ec6 on 9.0.x
    Issue #3387135: Fix null returns for Background colors with columns
    

  • Rajab Natshah committed ea7b8c69 on 10.0.x
    Issue #3387135: Fix null returns for Background colors with columns
    

  • Rajab Natshah committed 99f51bd7 on 9.0.x
    Issue #3387135: Fix null returns for Background colors with columns
    

  • Rajab Natshah committed d04dba26 on 9.1.x
    Issue #3387135: Fix null returns for Background colors with columns
    
rajab natshah’s picture

rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Title: Fix null returns for Background colors with columns » Fix null returns for Background colors with columns in Twig ~3
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-9.0.17

rajab natshah’s picture

Issue summary: View changes

✅ Released varbase-10.0.0-rc1