Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Some SAML providers - like the Belgian government - have their own authn contexts, so we should be able to add those.
Issue fork saml_sp-3385812
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
matthijsThis MR changes the return of saml_sp_authn_context_class_refs() and adds an alter hook.
Comment #4
jproctorThis is a great improvement but it changes the API for an existing public method.
Can we make it backwards compatible and add a deprecation warning? I don’t see an easy way to do that other than changing the function name (remove
class? spell outauthenticationorreferences?) but you may have another idea.Comment #5
matthijsI personally don't think changing the functions outcome is a problem since it's not a class method, but if you do I suggest to move my changes to a new function, use that everywhere and adjust the existing function to call the new one and return a value in the same format as before.
WDYT?
Comment #6
jproctorI kept looking at the old function when I was sketching ideas for #3118296: Add extra fields to config and thinking we could do better, and I knew we had talked about it somewhere.
I caught your branch up to current 4.x, renamed the new function because it still makes me twitchy to change an exposed function even though I know no one is using it, and will merge it and tag a release in the next day or so.
Comment #8
jproctor