Problem/Motivation

The module has tests but there are no testing configurations, so they do not get run.

Proposed resolution

Configure tests.

Issue fork toc_api-3384686

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Liam Morland created an issue. See original summary.

ericgsmith made their first commit to this issue’s fork.

ericgsmith opened merge request !10

ericgsmith’s picture

ericgsmith commented
Status: Active » Needs work

Added .gitlab-ci.yml example file - there are some tests that need cleanup before configuring scheduled tests / tests on MR.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

Failures are because of https://www.drupal.org/node/3030340 needs to be handled.

ericgsmith’s picture

ericgsmith commented
Status: Needs work » Needs review

Running properly now - the 2 failures appear to be #3417862: anchors add -01

Setting to needs review on the assumption any changes to the test / logic for the failing tests should be handled in #3417862: anchors add -01

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Tests are now passing. This is achieved partially by disabling some of the tests.

I suggest that this be merged. With this merged, at least some testing will be in place to help with other issues. The tests that have been disabled can be fixed and re-enabled in a follow-up issue.

The commits should get a clean-up before merge. I am happy to do this. Maintainer, please let me know if you agree with the direction of this and I will do the clean-up.

vladimiraus changed the visibility of the branch 8.x-1.x to hidden.

jannakha’s picture

jannakha commented
Status: Needs review » Reviewed & tested by the community

phpunit is green. Good to go.
Manually tested on D11.
+1 for RTBC

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Status: Reviewed & tested by the community » Fixed

Thank you. Committed. 🍰

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.