Problem/Motivation

Gin 8.x-3.0-rc6 was released on: 29 Aug 2023 by: saschaeggi
https://www.drupal.org/project/gin/releases/8.x-3.0-rc6


Thank you, Sascha, for all work on the Gin Admin theme

#3353113: Tour module button missing in frontend themes

#3384004: Update the Gin Admin Theme from 3.0.0-rc5 to 3.0.0-rc6 and keep needed patches

Wrong selector and wrong position

Proposed resolution

  • Change the Tour Switch selector to #toolbar-tab-tour and position to bottom

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 10.0.0-beta1, varbase_core-10.0.0-beta9

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

After the fix:
After the fix for the selector and position for the Tour Switch

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3384268: Fixed Tour Switcher selector and position after a fix in Gin for Tour module button missing in frontend themes

Comments

Rajab Natshah created an issue. See original summary.

  • Rajab Natshah committed ebe86a07 on 10.0.x
    Issue #3384268: Fix Tour Switcher selector and position after a fix in...
rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-10.0.0-beta1, +varbase_core-10.0.0-beta9
rajab natshah’s picture

Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

rajab natshah’s picture

Issue summary: View changes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.