Problem/Motivation

When upgrading Drupal from 9 to 10, I get an JavaScript error that says "$.cookie is not a function". This is due to Drupal 10 not including the jquery.cookie library anymore (deprecated in Drupal 9). For more information, refer to the relevant change record.

Steps to reproduce

- Install and enable bootstrap_site_alert on Drupal 10 site.
- Open developer tools and notice the errors on the JS console.

Proposed resolution

Use js-cookie library instead of jquery.cookie.

CommentFileSizeAuthor
#3 bootstrap_site_alert-replace-jquery-cookie-with-js-cookie-3383609-3.patch1.57 KBmmenavas
#2 bootstrap_site_alert-replace-jquery-cookie-with-js-cookie-3383609-2.patch1.34 KBmmenavas
jquery-cookie-error.png44.96 KBmmenavas

Comments

mmenavas created an issue. See original summary.

mmenavas’s picture

mmenavas commented
StatusFileSize
new bootstrap_site_alert-replace-jquery-cookie-with-js-cookie-3383609-2.patch1.34 KB

Attempt to fix this issue on 8.x-1.x branch.

mmenavas’s picture

mmenavas commented
StatusFileSize
new bootstrap_site_alert-replace-jquery-cookie-with-js-cookie-3383609-3.patch1.57 KB

Posting new patch as the pervious one wasn't working for me.

keshavv’s picture

keshavv commented
Status: Active » Needs review

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed

fixed in the 8.x-1.x branch only

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

camslice’s picture

camslice commented

hi joseph.olstad, will you be released a new tag on the 8.x-1.x branch that includes this fix? the current tag 1.10.0 does not seem to include the fix.

currently my composer.json looks like this 🙃

"drupal/bootstrap_site_alert": "dev-1.x#d0be53e24c5e2632795f8822564c06604fda2cc6"

additionally, it seems that dismissed-cookies.js is throwing an error on line 14:

12 ...
13 if (cookies.get('Drupal.visitor.bootstrap_site_alert_dismissed') !== key) {
14   $('.bs-site-alert').css('display', 'block');
15  }

cookies is undefined... which can be fixed by providing a default value on line 2:

1
2  (function ($, Drupal, cookies = {}) {
3  ...

thoughts?

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

My appologies @camslice.

https://www.drupal.org/project/bootstrap_site_alert/releases/8.x-1.12

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Closed (fixed) » Active
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://git.drupalcode.org/project/bootstrap_site_alert/-/commit/9531011...

camslice’s picture

camslice commented

Thanks @joseph :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.