Motivation

We built an "error" pattern in order to setup the error pages more quickly.

See also: (French) Page d'erreurs - Système de Design de l'État

It's a beta feature, but we could still add it to the build for now.

Issue fork ui_suite_dsfr-3383175

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

spryah created an issue. See original summary.

spryah opened merge request !26

spryah’s picture

spryah CreditAttribution: spryah commented
Status: Active » Needs review
pdureau’s picture

pdureau CreditAttribution: pdureau as a volunteer commented
Assigned: Unassigned » pdureau

Hi, thanks for your proposal.

I am not very comfortable about a component without any specific markup, being built with styles utilities classes and the layout system: https://git.drupalcode.org/project/ui_suite_dsfr/-/blob/e412e48eaecda579...

I need to think about that.

pdureau’s picture

pdureau CreditAttribution: pdureau as a volunteer commented
Assigned: pdureau » Unassigned
Status: Needs review » Postponed
pdureau’s picture

pdureau CreditAttribution: pdureau as a volunteer commented
Title: Add "error" pattern » Add "error" examples
Status: Postponed » Active

Let's implement theme as examples for now.

stephj’s picture

stephj CreditAttribution: stephj commented

The error pages are no more presented as beta features but are now included as models. See https://www.systeme-de-design.gouv.fr/composants-et-modeles/modeles/page... for further evolutions.

spryah’s picture

spryah CreditAttribution: spryah commented

Hi @pdureau!
I'm sorry I came back after so long.
For this issue I only updated my MR to add a "pictogram" settings.
This pattern has been very useful inside our projects up to now and I have trouble understanding how an example could be more useful to our developers?

pdureau’s picture

pdureau CreditAttribution: pdureau as a volunteer commented

hi Sorya,

When I see the wrapper element, I am still not convinced about this to be a genuine component:

<div class="fr-grid-row fr-grid-row--gutters fr-grid-row--middle fr-grid-row--center fr-my-3w">

Also, there are some issues:

  • the attributes object is not used
  • Some paths are hardcoded: <use class="fr-artwork-motif" href="/libraries/dsfr/dist/artwork/background/ovoid.svg#artwork-motif"></use>. Maybe the upcoming https://www.drupal.org/project/ui_icons may help here
pdureau’s picture

pdureau CreditAttribution: pdureau as a volunteer commented
Title: Add "error" examples » [1.1.x] Add "error" pages

So, from https://www.systeme-de-design.gouv.fr/composants-et-modeles/modeles/page... :

Anyway, moved to 1.1.x because all those pages rely heavily on pictograms (<svg class="fr-artwork">), which will be implemented with UI Icons.

pdureau’s picture

pdureau CreditAttribution: pdureau as a volunteer commented
Version: 1.0.x-dev » 1.1.x-dev