No idea if that's related to the upgrade from Drupal 9.5 to 10.1, but queued emails are no longer sent by the cron job. All I get is this warning in dblog:
Warning : Trying to access array offset on value of type null dans Drupal\Core\Cron->processQueue() (/var/www/html/drupal/core/lib/Drupal/Core/Cron.php ligne 264)
#0 /var/www/html/drupal/core/includes/bootstrap.inc(164): _drupal_error_handler_real()
#1 /var/www/html/drupal/core/lib/Drupal/Core/Cron.php(264): _drupal_error_handler()
#2 /var/www/html/drupal/core/lib/Drupal/Core/Cron.php(233): Drupal\Core\Cron->processQueue()
#3 /var/www/html/drupal/core/lib/Drupal/Core/Cron.php(162): Drupal\Core\Cron->processQueues()
#4 /var/www/html/drupal/core/lib/Drupal/Core/ProxyClass/Cron.php(75): Drupal\Core\Cron->run()
#5 /var/www/html/drupal/core/modules/automated_cron/src/EventSubscriber/AutomatedCron.php(65): Drupal\Core\ProxyClass\Cron->run()
#6 [internal function]: Drupal\automated_cron\EventSubscriber\AutomatedCron->onTerminate()
#7 /var/www/html/drupal/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()
#8 /var/www/html/drupal/vendor/symfony/http-kernel/HttpKernel.php(100): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
#9 /var/www/html/drupal/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(63): Symfony\Component\HttpKernel\HttpKernel->terminate()
#10 /var/www/html/drupal/core/lib/Drupal/Core/DrupalKernel.php(688): Drupal\Core\StackMiddleware\StackedHttpKernel->terminate()
#11 /var/www/html/drupal/index.php(22): Drupal\Core\DrupalKernel->terminate()
#12 {main}
From what I can see, this is due to a missing call to parent::__construct() from SendMailQueueWorker::__construct(). Patch attached. Please review.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3381103-queue_mail_fix_cron-1.patch | 3.6 KB | lpsolit |
Comments
Comment #2
lpsolit commentedOops, I forgot to fix the queue_mail_language submodule too.
Comment #3
lpsolit commentedComment #4
steven jones commentedLooks good to me.
Comment #6
steven jones commentedThanks very much for the bug report and the code, much appreciated!
I suppose we should get a test in that actually uses cron.
Comment #8
damienmckennaGiven how important this is to the module's functionality (should it have been a "major" issue?), does it warrant a new release?
Comment #9
steven jones commented@DamienMcKenna thanks very much for the nudge, I've created release 1.6 now.