Problem/Motivation

Using "use strict"; in global scope broke JS aggregation when core/loadjs library is loaded, as mentioned in #3336143-27: Uncaught ReferenceError: loadjs is not defined after drupal core upgrade 9.5.1.

Steps to reproduce

Proposed resolution

Move "use strict"; statement inside function

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 3379835-2-move-use-strict.patch453 bytesel7cosmos

Comments

el7cosmos created an issue. See original summary.

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
Status: Active » Needs review
StatusFileSize
new 3379835-2-move-use-strict.patch453 bytes
el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
Related issues: +#3336143: Uncaught ReferenceError: loadjs is not defined after drupal core upgrade 9.5.1
keshavv’s picture

keshavv commented
Status: Needs review » Reviewed & tested by the community

"use strict"; inside function works.

  • larowlan committed a9fc3b3a on 2.x authored by el7cosmos 
    Issue #3379835 by el7cosmos: Global 'use strict' statement broke JS...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Thanks, cutting alpha 2

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

sorry, I meant beta 3

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.