CommentFileSizeAuthor
#4 after_patch.png29.71 KBtanuja bohra
#4 before_patch.png30.91 KBtanuja bohra
#4 upgrade_status.png17.61 KBtanuja bohra

Issue fork academic_applications-3378556

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

xopoc created an issue. See original summary.

xopoc opened merge request !2

a_khalipau’s picture

a_khalipau commented
Issue summary: View changes
Status: Active » Needs review
tanuja bohra’s picture

tanuja bohra commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new upgrade_status.png17.61 KB
new before_patch.png30.91 KB
new after_patch.png29.71 KB

Verified the MR2 on 9.5.8, and 10.0.0 for drupal 10 compatibility. Added screenshots for reference, RTBC++

cilefen’s picture

cilefen commented
Issue summary: View changes

This merge doesn't adhere to Drupal code standards, indents in this case. Can we get that updated please?

cilefen’s picture

cilefen commented
Status: Reviewed & tested by the community » Needs work

@Tanuja Bohra You will not be given credit for screenshots of the update UI.

#3303963: Automated Drupal 10 compatibility fixes does one other change. Is that not needed?

drupler8’s picture

drupler8 commented

Hi cilefen and bkosborne, just for future planning purposes are you planning on a d10 release of this module. It may only have 23 people using it, but it is a really good and helpful module.

Thanks!

cilefen’s picture

cilefen commented

Sure. But we I need someone to test it because my organization no longer uses this module. The biggest issues, if any, will be with the Webform 6.2 integration. @drupler8 Are you using 2.x of this module with Webform 6.2 currently?

  • cilefen committed 1a3a54af on 3.x authored by xopoc 
    Issue #3378556 by xopoc, cilefen: Drupal 10 compatibility
cilefen’s picture

cilefen commented
Status: Needs work » Needs review

@drupler8 After some basic testing I released https://www.drupal.org/project/academic_applications/releases/3.0.0-alpha1 with Drupal 10 support. Please test it thoroughly.

Thank you @xopoc for the changes.

drupler8’s picture

drupler8 commented

@cilefen @xopoc amazing TY.

I am currently using 6.1.5, but I should have a d10 webform 6.2 site up soon to be able to test. I will keep you posted.

Thanks!

drupler8’s picture

drupler8 commented

Hi @cilefen @xopoc,

I have now been able to test this in Drupal 10.

It will be put through it's paces shortly, but it worked great.

I did get one php warning if you care:
Warning: Array to string conversion in Drupal\academic_applications\SubmissionBundler->bundle() (line 92 of /var/www/sites/drupal/ugsite/web/modules/contrib/academic_applications/src/SubmissionBundler.php).

I added an implode on line 92:
$name = !empty($submission->getData()['name']) ? '-' . implode("", $submission->getData()['name']) : '';

I will keep you posted if anything else comes up. Thanks again for taking the time to make this release!!

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.