Problem/Motivation

When a user clicks a link to subscribe to a forum taxonomy term, the label of the link is not updated correctly to display "Unsubscribe" until a page reload. And in some cases, a page reload does not even resolve the issue.

I noticed in the browser console I got an error message "User already subscribed\\/unsubscribed.". I also checked the DB and, in effect, the user was already subscribed to the forum but since the action of the link did not change to unsubscribe, the link is still pointing to the subscribe endpoint. This causes the error shown in the console.

I tried debugging the code and I noticed that the operations are cached in the Content Plugin of the Content submodule so the operations links to subscribe and unsubscribe are not updated correctly. Apparently, the change made here causes this issue https://www.drupal.org/project/danse/issues/3350871. The code that is causing the issue for me is in this function https://git.drupalcode.org/project/danse/-/commit/ea608668c414b78b2cc09565f5a1db16ccfb013c#46213d5ceb28331ceb6fbc0a9d40b66b17c95cbe_203_214.

Steps to reproduce

  1. Configure the module to display operations to subscribe to new published forum topics.
  2. Subscribe to a forum, and check if the label changes.
  3. In case the label changes, unsubscribe and subscribe again until it is not changing anymore.

Proposed resolution

Not sure if there is a way to disable this caching feature in sites with a small number of bundles.
Or an alternative is to cache only the array of the operation and calculate every time the action (Subscribe/ Unsubscribe) on the function subscriptionOperations.

Comments

s_castro created an issue. See original summary.

aroy-iqvia’s picture

aroy-iqvia commented

That's right, In the latest version, there's no way the user can unsubscribe after subscribing. Unless we clear the system cache. I had to revert to version 2.2.13 to fix the label.

walkero’s picture

walkero commented

I am experiencing the same problem with v2.3. I just started setting up this module, and it seems not to work properly because of this issue. I wonder if it is recommended to get back to the older version (2.2) and if there will be an update path in the future.

rex.barkdoll’s picture

rex.barkdoll commented

I'm adding in as well. I'm getting a 403 Ajax error whenever trying to unsubscribe.

Javascript in browser console:

Uncaught Drupal.AjaxError {message: '\nAn AJAX HTTP error occurred.\nHTTP Result Code: 40…essage":"User already subscribed\\/unsubscribed."}', name: 'AjaxError', stack: 'Error\n    at https://website.com/core/misc…website.com/core/misc/ajax.js?v=10.2.3:1916:3'}message: "\nAn AJAX HTTP error occurred.\nHTTP Result Code: 403\nDebugging information follows.\nPath: /api/danse/content/node/219/subscribe/content-node-219-1-comment\nStatusText: Forbidden\nResponseText: {\"message\":\"User already subscribed\\/unsubscribed.\"}"name: "AjaxError"stack: "Error\n    at https://website.com/core/misc/ajax.js?v=10.2.3:196:32\n    at https://website.com/core/misc/ajax.js?v=10.2.3:1916:3"[[Prototype]]: Error
    at https://website.com/core/misc/ajax.js?v=10.2.3:196:32
    at https://website.com/core/misc/ajax.js?v=10.2.3:1916:3constructor: ƒ (xmlhttp, uri, customMessage)stack: "Error\n    at https://website.com/core/misc/ajax.js?v=10.2.3:196:32\n    at https://website.com/core/misc/ajax.js?v=10.2.3:1916:3"[[Prototype]]: Objectconstructor: ƒ Error()message: ""name: "Error"toString: ƒ toString()[[Prototype]]: Object
Drupal.Ajax.error @ ajax.js?v=10.2.3:1219
complete @ ajax.js?v=10.2.3:608
c @ jquery.min.js?v=3.7.1:2
fireWith @ jquery.min.js?v=3.7.1:2
l @ jquery.min.js?v=3.7.1:2
(anonymous) @ jquery.min.js?v=3.7.1:2
load (async)
send @ jquery.min.js?v=3.7.1:2
ajax @ jquery.min.js?v=3.7.1:2
Drupal.Ajax.eventResponse @ ajax.js?v=10.2.3:799
(anonymous) @ ajax.js?v=10.2.3:646
dispatch @ jquery.min.js?v=3.7.1:2
v.handle @ jquery.min.js?v=3.7.1:2

dblog error:

Path: /api/danse/content/node/219/subscribe/content-node-219-1-comment?_wrapper_format=drupal_ajax. Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException: User already subscribed/unsubscribed. in Drupal\Core\Routing\AccessAwareRouter->checkAccess() (line 118 of /var/www/html/website.com/web/core/lib/Drupal/Core/Routing/AccessAwareRouter.php).

  • jurgenhaas committed 142e0255 on 2.3.x 
    Issue #3377551: Link label is not updated correctly after user Subscribe...
jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Version: 2.2.17 » 2.3.x-dev
Status: Active » Needs review

Your observation was absolutely right @s_castro that the caching was the reason for this broken behaviour. That was introduced in #3350871: Huge performance issue on sites with a lot of entity types and bundles and increased the performance a lot. However, it cached the widget operations per entity type and entity id, but forgot about the user. These widgets are individual for each entity per user, so the user ID needs to go into the cache ID as well.

That alone didn't fix it yet. We also need to reset the cache for an entity if the subscription status for that entity changes for a specific user.

Both parts have been fixed and it seems to be working correctly now. Please give it a try.

rex.barkdoll’s picture

rex.barkdoll commented
Version: 2.3.x-dev » 2.2.17
Status: Needs review » Active

Upgrading to the current dev version fixed my issue and seems to be working well.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Version: 2.2.17 » 2.3.x-dev
Status: Active » Fixed

Thanks for testing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.