Problem/Motivation

Icon is missing and path dividers are faint

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 Gin-breadcrumb.png67.01 KBmukeysh
#7 3377216-6.patch2.38 KBbunty oberoi
#5 fixed_slash_and_pipe.png14.7 KBMoni_10
#5 3377216-5.patch1.85 KBMoni_10
#3 fixed_breadcrumb_icon.png12.86 KBMoni_10
#3 3377216-3.patch977 bytesMoni_10
Screen Shot 2023-07-26 at 2.20.02 PM.png14.68 KBbnjmnm

Issue fork gin-3377216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

Moni_10’s picture

Moni_10 commented

Thanks @bnjmnm. Working on this.

Moni_10’s picture

Moni_10 commented
Status: Active » Needs review
StatusFileSize
new 3377216-3.patch977 bytes
new fixed_breadcrumb_icon.png12.86 KB

Hi @bnjmnm, Here's the patch to fix this issue. Also, I have attached screenshot after fix. Please review

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Needs work

This should also fix the pipe, which in the issue summary screenshot separates "back to site" and "administration" as well as the slash, which in that same screenshot separates "administration" and "structure"

Moni_10’s picture

Moni_10 commented
Status: Needs work » Needs review
StatusFileSize
new 3377216-5.patch1.85 KB
new fixed_slash_and_pipe.png14.7 KB

Sure thanks @bnjmnm. Created new patch to fix the visibility of pipe and slash icon with attached screenshot. Please review.

bunty oberoi’s picture

bunty oberoi
Location Dharamshala
commented
Assigned: bnjmnm » bunty oberoi
Status: Needs review » Needs work

Hi Moni_10,
Verified and tested Patch Comment #5 on Drupal 10.1.0-dev Applied patch cleanly

oberoi@oberoi-H510M-S2:~/Documents/projects/drupal/themes/contrib/gin$ git apply -v 3377216-5.patch
Checking patch dist/css/components/breadcrumb.css...
Checking patch styles/components/breadcrumb.scss...
Applied patch dist/css/components/breadcrumb.css cleanly.
Applied patch styles/components/breadcrumb.scss cleanly.

Testing Steps:-
1. Install Drupal 10.1.x version.
2. git clone --branch '8.x-3.x' https://git.drupalcode.org/project/gin.git
2. Applied Patch #5 /Documents/projects/drupal/themes/contrib/gin
3. Checked the changes difference using git diff
4. Installed theme and set it as default.
5. Enable emulate css forced-color

Testing result:
3377216-5.patch fixing the above issue.
Observation:- back to site before icon disappears on hover.

bunty oberoi’s picture

bunty oberoi
Location Dharamshala
commented
StatusFileSize
new 3377216-6.patch2.38 KB

Adding a patch to fix the hover issue. Please review.

bunty oberoi’s picture

bunty oberoi
Location Dharamshala
commented
Status: Needs work » Needs review
mukeysh’s picture

mukeysh commented
Assigned: bunty oberoi » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Gin-breadcrumb.png67.01 KB

I have tested the above #7 patch the breadcrumb icon and back icon are visible properly. Attaching a screenshot for reference.

saschaeggi’s picture

saschaeggi
he/him
commented
Title: Breadcrumb icon & dividers forced-color visbility issues » [a11y] Breadcrumb icon & dividers forced-color visbility issues
Status: Reviewed & tested by the community » Fixed

Thanks 👏

saschaeggi’s picture

saschaeggi
he/him
commented
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed
saschaeggi’s picture

saschaeggi
he/him
commented
Title: Breadcrumb icon & dividers forced-color visbility issues » [a11y] Breadcrumb icon & dividers forced-color visbility issues

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.