Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#12 After-patch.png332.7 KBdjsagar
#12 Before-patch.png364.21 KBdjsagar
#11 drupal-10.1.2.png349.33 KBdjsagar
#10 Screenshot from 2023-08-01 15-42-29.png62.72 KBindrapatil
#9 gin-messsage-force-color-mode.png91.13 KBmukeysh
#8 Screen Shot 2023-07-31 at 8.39.59 AM.png91.33 KBbnjmnm
#7 gin-forced-color.png199.74 KBmukeysh
#5 icon-not-visible.png243.52 KBpreeti.chawla
#4 error-while-apply-patch.png80.57 KBpreeti.chawla
#3 Screen Shot 2023-07-26 at 1.31.01 PM.png53.16 KBbnjmnm
Screen Shot 2023-07-26 at 1.23.45 PM.png61.27 KBbnjmnm

Issue fork gin-3377202

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !288

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2023-07-26 at 1.31.01 PM.png53.16 KB

Fix in MR.

preeti.chawla’s picture

preeti.chawla commented
StatusFileSize
new error-while-apply-patch.png80.57 KB

@bnjmnm I have not able to apply patch. There is something wrong, Even I have tried to add code manually and I check "buttonBorder" variable not declared anywhere

preeti.chawla’s picture

preeti.chawla commented
StatusFileSize
new icon-not-visible.png243.52 KB

@bnjmnm Now I have tried to apply patch with this version Drupal9.5 and Gin 8.x-3.x-dev, Patch applied successfully but icons still not visible for me

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
@bnjmnm Now I have tried to apply patch with this version Drupal9.5

This is a merge request, just copy paste the git commands in "show commands" to switch to the fork/branch instead of trying to treat a merge request as a patch.

buttonBorder" is not a variable that needs to be declared

That is correct, and not at all a problem. It's a system color, which is a best practice for providing fixed colors styling.

Patch applied successfully but icons still not visible for me

Without additional information I have to assume user error. It clearly works for me and I can't do much with "still not visible for me". Did you check your browser dev tools to confirm the styles added in the MR are present in the CSS ingested by the browser?

mukeysh’s picture

mukeysh commented
StatusFileSize
new gin-forced-color.png199.74 KB

@bnjmnm
I have tested the code the cross icon is there but not visible properly. I am attaching a screenshot for reference.

This is working fine when we have only enabled the forced colors mode but when we enabled the automatic dark color mode and force active color mode then the icon is not visible properly.

PS: I have tested this on Chrome Version 115.0.5790.110 and the Operating system is Ubuntu 22.04

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new Screen Shot 2023-07-31 at 8.39.59 AM.png91.33 KB

That's a helpful explanation @Mukeysh, I now know what is happening here.

Automatic dark color mode is a Chrome experimental feature that can only be enabled via dev featurs. Drupal / Gin can't be expected to support Chrome experimental features, and is

To test dark themed forced colors mode, which is recognized by all Drupal supported browsers, choose prefers-color-scheme: dark in the "Emulate CSS media feature prefers-color-scheme" option.

mukeysh’s picture

mukeysh commented
StatusFileSize
new gin-messsage-force-color-mode.png91.13 KB

@bnjmnm
It looks fine then attaching a screenshot for reference. I have noticed the message icon is not visible so I have made fixes in the MR.

indrapatil’s picture

indrapatil commented
StatusFileSize
new Screenshot from 2023-08-01 15-42-29.png62.72 KB

I reviewed this patch. I attached the screenshot.

djsagar’s picture

djsagar commented
StatusFileSize
new drupal-10.1.2.png349.33 KB

Hi All,

This issue not replicate on drupal 10.1.2 with fin 8.x-3.x.

Please have look.

Thanks!

djsagar’s picture

djsagar commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Before-patch.png364.21 KB
new After-patch.png332.7 KB

So finally i applied this patch #9 in drupal 10.1.2 with fin 8.x-3.x. It's working as expected.
I attached the screenshot for reference.

Thanks!

saschaeggi made their first commit to this issue’s fork.

  • saschaeggi committed 2a3db38e on 8.x-3.x authored by bnjmnm 
    Issue #3377202: messages close icon not visible in forced colors mode
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks y'all 🤝

saschaeggi’s picture

saschaeggi
he/him
commented
Title: messages close icon not visible in forced colors mode » [a11y] messages close icon not visible in forced colors mode

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.