Problem/Motivation

I have run phpcs on the module and found there are many unused statements and statements are not in alphabetical order.
Attached report for the same.

Steps to reproduce

Remove unused use statements.
Reorder use statements alphabetically.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#3 captcha-phpcs.txt11.74 KBkeshavv

Issue fork captcha-3376818

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

keshav.k created an issue. See original summary.

keshav.k opened merge request !79

keshavv’s picture

keshavv commented
Status: Active » Needs review
StatusFileSize
new captcha-phpcs.txt11.74 KB

I have fixed the issue and created the MR.
Kindly ignore the JS Boolean error eg. true to TRUE. It will throw an error.
Please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

@Grevil could you review these, please?

Grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

Changes LGTM! Added a few further fixes.

  • Grevil committed 17c8dac4 on 2.x authored by keshav.k 
    Issue #3376818: Remove unused use statements and sort them...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed
grevil’s picture

grevil commented
Assigned: grevil » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.