Problem/Motivation

Since, 3.0.0 module adds CSS class "ui-menu-item" to <li> elements, but this is not needed. Actually, it breaks a proper HTML structure, because <a> elements inside are lacking a few things

Steps to reproduce

See https://git.drupalcode.org/project/drupal/-/blob/11.x/core/assets/vendor...

Proposed resolution

Remove code that adds the mentioned CSS class

Remaining tasks

Review patch

User interface changes

Fix regression of missing jQuery UI classes

API changes

None

Data model changes

None

Issue fork search_autocomplete-3376483

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Taran2L created an issue. See original summary.

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Issue summary: View changes

Taran2L opened merge request !2

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
Status: Active » Needs review
pasan.gamage’s picture

pasan.gamage commented

This patch worked for me on D10
Thanks @Taran2L

pasan.gamage’s picture

pasan.gamage commented
Status: Needs review » Reviewed & tested by the community
tomtech’s picture

tomtech commented
Status: Reviewed & tested by the community » Needs work

Thanks for the MR, @Taran2L !

It did resolve an issue with the groups not rendering correctly for the search autocomplete field, but it also broke all the other regular autocomplete fields on the site.

Not sure why the processing is different, but I've made a small tweak to the patch that keeps the `ui-menu-item` class for autocompletes that are not search_autocompletes, and this at least allows both to function.

New MR to follow.

TomTech opened merge request !3

tomtech’s picture

tomtech commented
Status: Needs work » Needs review

New MR added that only adds the class if the autocomplete is NOT a search autocomplete.

extexan’s picture

extexan commented

Just to weigh in on this issue, our non-search autocompletes were broken. The MR from TomTech fixed them.

dom. made their first commit to this issue’s fork.

  • dom. committed 030f6d8c on 3.x authored by tomtech 
    Issue #3376483: CSS class "ui-menu-item" must not be added by the module...
dom.’s picture

dom. commented
Status: Needs review » Fixed

Thanks a lot awesome community for your work on this module.
3.0.1 includes your fix

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.