Problem/Motivation

Relying on entity queries to check access by default is deprecated in drupal:9.2.0 and an error will be thrown from drupal:10.0.0. Call \Drupal\Core\Entity\Query\QueryInterface::accessCheck() with TRUE or FALSE to specify whether access should be checked.

See https://www.drupal.org/node/3201242

Proposed resolution

Add accessCheck(FALSE) for entityQuery in src/Controller/TagcloudsPageChunk.php::chunk()

Issue fork tagclouds-3375956

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

szato created an issue. See original summary.

szato opened merge request !4

szato’s picture

szato commented
Assigned: szato » Unassigned
Status: Active » Needs review

Created MR with fix.

  • joseph.olstad committed f52f44a2 on 2.0.x authored by szato 
    Issue #3375956: QueryInterface::accessCheck is required on Drupal 10
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Fixed
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/project/tagclouds/releases/2.0.6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

erwangel’s picture

erwangel commented

line 68

if (empty($vocs)) {
$query = $this->entityTypeManager()
->getStorage('taxonomy_vocabulary')
->accessCheck(FALSE)
->getQuery();

Should be

if (empty($vocs)) {
$query = $this->entityTypeManager()
->getStorage('taxonomy_vocabulary')
->getQuery()
->accessCheck(FALSE);

Otherwise you get "Call to undefined method Drupal\taxonomy\VocabularyStorage::accessCheck"....

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Closed (fixed) » Active

  • joseph.olstad committed 6b664a24 on 2.0.x 
    Issue #3375956 by szato, joseph.olstad, erwangel: QueryInterface::...
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

https://www.drupal.org/project/tagclouds/releases/2.0.10

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.