Problem/Motivation

Not sure if this was the intended result for the approach that was merged on Refactor Claro's "node form" layout to not use floats, but the new approach makes the "footer" region of the form only appears after the "secondary" region's height when the "main" region has a smaller height than the "secondary" region.

One case that you might need a content type with just the title is a content type that uses Layout Builder to create all the content

Steps to reproduce

  • Get any content type and remove all fields from it, leaving only the Title field
  • Go to add a new node of that content type
CommentFileSizeAuthor
#10 3375600-form_layout_test_evidence.gif4.21 MBcarolpettirossi
#7 3375600-form_layout_main_region_broken-7.patch1.58 KBcarolpettirossi
#5 3375600-rtl-after-patch.png109.14 KBcarolpettirossi
#4 image (10).png198.41 KBgabriel.passarelli
#2 3375600.gif3.08 MBcarolpettirossi
image (9).png170.01 KBgabriel.passarelli

Issue fork drupal-3375600

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gabriel.passarelli created an issue. See original summary.

carolpettirossi’s picture

carolpettirossi commented
StatusFileSize
new 3375600.gif3.08 MB

I'm facing the same issue on a clean install of Drupal 10.1.1.

See the test evidence below:
GIF showing the steps/scenarios of the issue reported

gabriel.passarelli opened merge request !4406

gabriel.passarelli’s picture

gabriel.passarelli commented
Status: Active » Needs review
StatusFileSize
new image (10).png198.41 KB

I've created an MR that adds grid-row and grid-column attributes for the .layout-node-form elements.

Before the changes
Before Changes
After the changes
After Changes

carolpettirossi’s picture

carolpettirossi commented
StatusFileSize
new 3375600-rtl-after-patch.png109.14 KB

I applied the patch from the MR, and it worked as expected.

I can also confirm that with an RTL language, the form layout is correct too.

RTL interface after patch applied

carolpettirossi’s picture

carolpettirossi commented
Status: Needs review » Reviewed & tested by the community
carolpettirossi’s picture

carolpettirossi commented
StatusFileSize
new 3375600-form_layout_main_region_broken-7.patch1.58 KB

Attaching patch from the MR to use in composer.json

Gauravvvv made their first commit to this issue’s fork.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Needs review

Thank you all for working on this! Asked one question on MR

carolpettirossi’s picture

carolpettirossi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 3375600-form_layout_test_evidence.gif4.21 MB

I'm not sure why Tugboat env is not working on this issue.

I applied the latest changes on my sandbox, and it works as expected, including RTL language. It also doesn't affect CTs with more fields that were working previously. See the evidence below:

Test evidence. Screencast after applying latest MR showing the bug has been fixed.

  • lauriii committed 4511b7f6 on 11.x 
    Issue #3375600 by gabriel.passarelli, Gauravvvv, carolpettirossi: Form...

  • lauriii committed 7ec47764 on 10.1.x 
    Issue #3375600 by gabriel.passarelli, Gauravvvv, carolpettirossi: Form...

lauriii closed merge request !4406

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Reviewed & tested by the community » Fixed

Thanks for getting that addressed @gabriel.passarelli and for testing it @carolpettirossi! 😊

Committed 4511b7f and pushed to 11.x. Thanks! Also cherry-picked to 10.1.x as a non-disruptive bug fix.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.