Problem/Motivation

There's an design breaks in view's modal where modal's border and close icon is not visible.

Steps to reproduce

  1. Create an view.
  2. Go the view and add fields to it and modal will open.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 forced-color-mode-after-patch-4.png252.21 KBpreeti.chawla
#5 forced-color-mode-before-patch-4.png163.81 KBpreeti.chawla
#4 3375258-4.patch1.39 KBVidushi Mehta
#4 patch-does-not-apply.png28.31 KBVidushi Mehta
#4 force-color-mode-issue.png71.19 KBVidushi Mehta
#3 high-contrast-mode.png84.56 KBVidushi Mehta
#2 3375258_#2.patch2.61 KBMoni_10
#2 after_modal.png256.09 KBMoni_10
before_modal.png235.98 KBMoni_10

Comments

Moni_10 created an issue. See original summary.

Moni_10’s picture

Moni_10 commented
Status: Active » Needs review
StatusFileSize
new after_modal.png256.09 KB
new 3375258_#2.patch2.61 KB

Hi, I've created a patch to fix that issue. Attaching after_modal.png screenshot as well.

Vidushi Mehta’s picture

Vidushi Mehta commented
StatusFileSize
new high-contrast-mode.png84.56 KB

I checked this issue by above mentioned steps to reproduce but couldn't find the same after enabling the high contrast mode, is there anything that I've missed please let me know, attaching the screenshot for the same

Vidushi Mehta’s picture

Vidushi Mehta commented
StatusFileSize
new force-color-mode-issue.png71.19 KB
new patch-does-not-apply.png28.31 KB
new 3375258-4.patch1.39 KB

I got to know my mistake and found the same issue in force color mode, I've applied #2 for review but it does not apply so adding the new patch for the same and attaching the screenshot of the existing issue

preeti.chawla’s picture

preeti.chawla commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new forced-color-mode-before-patch-4.png163.81 KB
new forced-color-mode-after-patch-4.png252.21 KB

@Vidushi Mehta I have applied #4 to review and patch applied successfully. View's modal popup icons working fine, Adding Screenshot Before and After state as well. Moving to RTBC

saschaeggi’s picture

saschaeggi
he/him
commented
Title: View's modal design and icon breaks in forced colors/High contrast mode. » [a11y] View's modal design and icon breaks in forced colors/High contrast mode.
Status: Reviewed & tested by the community » Fixed

Thanks y'all 👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.