Problem/Motivation
- Having the old naming convention for VMI
- Issue #3374893: Add Card styling for Card Border, Anchor All, Card Size and Equal height variations
- ✅ Released varbase_components-2.0.0-alpha13
Proposed resolution
Follow with #3374893: Add Card styling for Card Border, Anchor All, Card Size and Equal height variations
Change to Card naming convention in SCSS variables in Vartheme custom variables
- Card's default h3 title font size.
- Overlay Card default styles.
- Hero Card default styles.
The _vartheme-variables.scss in Vartheme BS5 starterkit theme which matches the same name of file in Varbase Components
Both have the same custom Vartheme custom variables and the same file name.
// Vartheme custom variables // ----------------------------------------------------------------------------- // Card's default h3 title font size. $card-xlarge-title-font-size: 2rem; $card-large-title-font-size: 1.8rem; $card-medium-title-font-size: 1.4rem; $card-small-title-font-size: 1.4rem; $card-xsmall-title-font-size: 1.2rem; // Overlay Card default styles. $overlay-card-title-color: #fff; $overlay-card-xlarge-title-font-size: 4rem; $overlay-card-content-color: #fff; $overlay-card-content-stop1-location: 65%; $overlay-card-content-stop1-color: transparent; $overlay-card-content-stop2-location: 105%; $overlay-card-content-stop2-color: #000; $overlay-card-content-hover-opacity: 0.9; // Hero Card default styles. $hero-card-title-color: #fff; $hero-card-xlarge-title-font-size: 3rem; $hero-card-content-hover-opacity: 0.7; $hero-card-content-background-color1: rgb(0,0,0); $hero-card-content-background-color2: rgba(0,0,0,0.7);
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release Varbase 10.0.0-beta1, vartheme_bs5-3.0.0-alpha10
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3374946: Switched from the old View Modes Inventory (VMI)'s variables to the Card naming convention following Varbase SDC Cards components
Comments
Comment #2
rajab natshahComment #4
rajab natshahComment #5
rajab natshahComment #6
rajab natshahComment #7
rajab natshahComment #8
rajab natshah✅ Released vartheme_bs5-3.0.0-alpha10
Comment #9
rajab natshahComment #11
rajab natshah✅ Released Varbase 10.0.0-beta1