Problem/Motivation

"SpamSpanComplexHtmlMailToTest" and "SpamSpanSimpleHtmlTest" are very similiar and there is no real reason to split these classes. Put them together.
"SpamSpanFilterUnitTest" should partially implement a dataProvider testing method, instead of copy pasting tests.

Steps to reproduce

Proposed resolution

Fix as described

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork spamspan-3374707

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

Grevil opened merge request !18

grevil’s picture

grevil commented
Status: Active » Needs review

Done, please review.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Good catch! RTBC once green :)

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

All green.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.