Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 3374131 after MR.png29.83 KBHarish1688
#4 3374131 before MR.png24.43 KBHarish1688
#3 tabledrag-after.png43.47 KBbnjmnm
tabledrag-before.png38.48 KBbnjmnm

Issue fork gin-3374131

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !277

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
StatusFileSize
new tabledrag-after.png43.47 KB

MR makes the handle and "dragged" bar visible in forced colors mode.

Harish1688’s picture

Harish1688 commented
StatusFileSize
new 3374131 before MR.png24.43 KB
new 3374131 after MR.png29.83 KB

Hi,

Tested the MR !277 to address the issue tabledrag handle and "dragged" bar not visible in forced color. it's works fine, issue points (handle and dragged bar visibility ) are covered in MR:

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. on path 'admin/structure/menu/manage/main', enable the ( "Emulate CSS media feature forced-colors" ) in 'active" mode.
3. Switch to MR and verified the changes in update MR.

attached the screen for references.
Before:
issue image
After:
issue image

Looks Good for RTBC

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Needs review » Reviewed & tested by the community

The comment in #4 said this was good to RTBC, but the status was not changed. I'm changing it as it looks like that was their intent.

saschaeggi made their first commit to this issue’s fork.

  • saschaeggi committed 10f15746 on 8.x-3.x authored by bnjmnm 
    Issue #3374131: Tabledrag handle and "dragged" bar not visible in forced...
saschaeggi’s picture

saschaeggi
he/him
commented
Title: Tabledrag handle and "dragged" bar not visible in forced colors (high contrast) mode » [a11y] Tabledrag handle and "dragged" bar not visible in forced colors (high contrast) mode
Status: Reviewed & tested by the community » Fixed

Thanks! 👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.