Problem/Motivation

All the other toolbar items have a nice focus outline, but the home link does not.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#10 after-patch-vertical.png76.4 KBlokeshsahu
#10 after-patch-horizontal.png202.65 KBlokeshsahu
#6 cut.png19.4 KBsaschaeggi
#4 3373964 horizontal.png25.06 KBHarish1688
#4 3373964 vertical.png31.65 KBHarish1688
#3 Screen Shot 2023-07-11 at 1.21.28 PM.png62.81 KBbnjmnm

Issue fork gin-3373964

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

bnjmnm opened merge request !272

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Status: Active » Needs review
StatusFileSize
new Screen Shot 2023-07-11 at 1.21.28 PM.png62.81 KB

The changes in the MR makes it so the focus state matches that of the other items in the toolbar.

Harish1688’s picture

Harish1688 commented
StatusFileSize
new 3373964 vertical.png31.65 KB
new 3373964 horizontal.png25.06 KB

Hi,

Tested the MR !272 to address the issue where the focus outline was not appearing on the home link. it's now works perfectly fine in both vertical and horizontal views.

Testing Steps:
1. Install the Drupal 10.0.x version and enable gin 8.x.
2. switch to MR and verified the changes.

attached the screen for references.
issue image

issue image

Looks Good for RTBC

hebl’s picture

hebl commented
Status: Needs review » Reviewed & tested by the community

+1 LGTM, moving to RTBC

Nice work @bnjmnm!

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new cut.png19.4 KB

Moving this back to needs work as the focus cuts off when using the vertical toolbar.

hebl’s picture

hebl commented

Ooops, didn't spot that. Sorry @saschaeggi. Will take a look for a fix this afternoon.

hebl’s picture

hebl commented
Status: Needs work » Needs review

Hey @saschaeggi,

I've added a small change to the existing MR which corrects the previous issue with the focus being cut off.

I've checked this on both the horizontal and vertical toolbar.

Please could you take another look? Thanks!

lokeshsahu’s picture

lokeshsahu commented

Reviewing this issue.

lokeshsahu’s picture

lokeshsahu commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new after-patch-horizontal.png202.65 KB
new after-patch-vertical.png76.4 KB

I have tested the recent MR #7 to verify the issue mentioned in #6 and it is working fine without getting cut off while on focus on the vertical toolbar. The MR works totally fine for the horizontal toolbar as well. I am attaching a screenshot for reference after applying the MR.
Looks Good for RTBC++

hebl’s picture

hebl commented

Hey @saschaeggi,

Would you mind taking another look at this now it's been fixed and tested by the community?

Thanks

Luke

  • saschaeggi committed fce0b5fe on 8.x-3.x authored by bnjmnm 
    Issue #3373964: Focus state not visible for "Home" icon in toolbar.
saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Great work, thanks 👏

saschaeggi’s picture

saschaeggi
he/him
commented
Title: Focus state not visible for "Home" icon in toolbar. » [a11y] Focus state not visible for "Home" icon in toolbar.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.