Problem/Motivation

Since the last update, the delete button is no longer visible for non-admin users on the comment itself, severely reducing the usability of this module.

Steps to reproduce

Have working setup and update to the latest version, delete buttons are gone from comments

CommentFileSizeAuthor
#5 contenttype.png61.41 KBklemendev

Comments

KlemenDEV created an issue. See original summary.

bobooon’s picture

bobooon commented
Status: Active » Postponed (maintainer needs more info)

What are your permission settings? What are your comment delete settings? Please provide specific steps to replicate.

klemendev’s picture

klemendev commented

I use the "hard delete" option. Permission to hard delete is given to authenticated user roles for the desired content type, as well as "Delete own comments" permission.

On content type configuration, only hard delete is allowed, operation visibility is "Visible when multiple operations are available", default labels, and 60 seconds for the "Delete time limit" which is enabled

Steps to replicate are to update the module to the latest version and the button ("Delete" button on the comments) that was there before is gone after the update, checking logs no errors are logged. However, the button is visible to admin that can delete comments in general.

bobooon’s picture

bobooon commented

Would you mind providing a screenshot of both the comment delete and permissions table configurations? Or a configuration export.

klemendev’s picture

klemendev commented
StatusFileSize
new contenttype.png61.41 KB

Attached is the content type config.

Authenticated user has the following permissions (I can't screenshot this page due to confidentiality):

* "Content: Allow (content type) Comments hard delete"
* "Delete own comments"

bobooon’s picture

bobooon commented

Thanks. The role that's having issues only has permissions to hard delete, correct? Also you have the delete time limit option enabled and set to 60 seconds. Are you testing as that role on a comment that has been created less than 60 seconds ago?

klemendev’s picture

klemendev commented

Are you testing as that role on a comment that has been created less than 60 seconds ago?

Yes, it is done in 60 seconds timeframe. The testing also goes well if the module version is reverted (same config and same test procedure).

bobooon’s picture

bobooon commented
Assigned: Unassigned » bobooon
Status: Postponed (maintainer needs more info) » Active

Confirmed. Regression introduced in #3336542: Call to undefined method BaseFieldDefinition::getThirdPartySettings().

  • 4141b4e5 committed on 2.x 
    Issue #3373895: Fixes access regression introduced in #3336542
bobooon’s picture

bobooon commented
Status: Active » Fixed
klemendev’s picture

klemendev commented

Neat, thank you for taking a look into this and fixing it :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.