Problem/Motivation

Because the secondary toolbar can include items also in the primary toolbar, the #toolbar-item-user id can appear twice on the same page which can lead to JS errors and results in basic accessibility scans failing.

There are other duplicate id problems that are best addressed in the gin_toolbar module, which will get its own issue, but this one is most easily addressed in the theme itself.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork gin-3373557

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

bnjmnm’s picture

Status: Active » Needs review

saschaeggi made their first commit to this issue’s fork.

  • saschaeggi committed cc642a4e on 8.x-3.x authored by bnjmnm
    Issue #3373557: #toolbar-item-user id can appear twice when user item...
saschaeggi’s picture

Status: Needs review » Fixed

Great, thanks @bnjmnm 👏

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.