Problem/Motivation

This module is blocking use of domain 2.x due to version constraint in composer.json (which might be there for a good reason).

Steps to reproduce

Attempt to upgrade domain to 2.x on site with this module in composer.json:

- drupal/domain_menu_access is locked to version 2.0.0-alpha3 and an update of this package was not requested.
- drupal/domain_menu_access 2.0.0-alpha3 requires drupal/domain ^1 -> found drupal/domain[1.0.0-beta1, ..., 1.0.0-beta8] but it conflicts with your root composer.json require (^2.0@beta).

Proposed resolution

Initially just allow both 1.x and 2.x of domain, get it installed, then do some testing.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork domain_menu_access-3372512

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dubois created an issue. See original summary.

dubois opened merge request !7

dubois’s picture

dubois commented
Assigned: dubois » Unassigned
Status: Active » Needs review

Using the forked version requires a number of changes to composer.json:

  • Update repositories section to exclude getting releases of this module and add repo pointing to fork:
        "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8",
            "exclude": [
                "drupal/domain_menu_access"
            ]
        },
        {
            "type": "git",
            "url": "https://git.drupalcode.org/issue/domain_menu_access-3372512.git"
        }
    ],
  • Required the change dev branch:
    "drupal/domain_menu_access": "dev-3372512-make-compatible-with",

Module works as expected with domain 2.0.0-beta1. This is a trivial change so suggest so hope we can get it merged soon.

bruno_lima’s picture

bruno_lima commented
Status: Needs review » Reviewed & tested by the community

+1 for #2

Patch applies cleanly in current version (2.0.0-alpha3).

Still had to manually update composer.lock to add '^2' in the dependency string in order to get domain updated to '2.0.0-beta1', since composer.lock is generated before patches are applied.

Module works with domain version 2.x just fine, as expected.

This is a very simple change, so let's get this merged!

Cheers.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented

Let me look to get this committed.

  • tim-diels committed c3204f4a on 2.0.x authored by dubois 
    Issue #3372512 by dubois, tim-diels: Make compatible with domain 2.x
tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Good work dubois!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.