Problem/Motivation

#3356894: Make field selection less overwhelming by introducing groups added a new theme suggestions hook field_ui_theme_suggestions_form_element_alter but we could just specify the wrapper at the source

Additionally, we're switching out a theme hook for a base hook but changing from 'render elements' to 'variables' which technically isn't supported.

Steps to reproduce

Proposed resolution

Specify the wrapper at the source instead
Switch back to 'render elements' instead of 'variables'

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3372089.patch2.53 KBlarowlan

Comments

larowlan created an issue. See original summary.

larowlan’s picture

StatusFileSize
new2.53 KB
lauriii’s picture

Status: Needs review » Reviewed & tested by the community

Definitely cleaner 👍 Thanks @larowlan!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3372089.patch, failed testing. View results

larowlan’s picture

Status: Needs work » Reviewed & tested by the community

Rando fail

  • bnjmnm committed 5ea65c99 on 11.x
    Issue #3372089 by larowlan, lauriii: Remove...
bnjmnm’s picture

Status: Reviewed & tested by the community » Fixed

Glad you spotted that @larowlan. Looks like that landed as part of a very big commit, and it's not surprising a best practice or two was missed. This also serves as evidence that we can optimize things after the fact, and sometimes it's most effective to just get a feature in and it'll eventually get to "perfect".

Committed to 11.x

larowlan’s picture

💯 velocity > perfection

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.