Problem/Motivation

Experimented with the following

But facing issue with starterkit generated themes and replacement of SDC components
From Varbase Components, Vartheme BS5 , and Generated theme
with duplicate SDC components or messing components

Proposed resolution

Keep the Starterkit Vartheme BS5 inline with Varbase Components, for an out of the box working Generated theme.

Having a smoother out of the box working Generated theme management

How to use the Vartheme BS5 Starterkit

To generate a new theme from Vartheme BS5 using the starterkit/theme-generation script, run the following from Drupal's installation root:

cd PROJECT_DIR_NAME/docroot

Run the following Drupal Generate Theme script:
php core/scripts/drupal generate-theme new_theme_name --starterkit vartheme_bs5

Only generative theme

Vartheme BS5 - Is only a starterkit and a drupal template mapper to ( include, embed, extend ) for SDC components by Varbase Components.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ✅ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ✅ Release Varbase 10.0.0-beta1, vartheme_bs5-3.0.0-alpha7

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Issue #3371835: Removed all SDC components out from Vartheme BS5 and include them from Varbase Components for a smoother out of the box working Generated theme management
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Rajab Natshah created an issue. See original summary.

rajab natshah’s picture

Title: Remove all SDC components from Vartheme BS5 and include them from Varbase Components » Remove all SDC components out from Vartheme BS5 and include them from Varbase Components
Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

  • Rajab Natshah committed 736290f9 on 3.0.x
    Issue #3371835: Remove all SDC components out from Vartheme BS5 and...
rajab natshah’s picture

Title: Remove all SDC components out from Vartheme BS5 and include them from Varbase Components » Remove all SDC components out from Vartheme BS5 and include them from Varbase Components for a smoother out of the box working Generated theme management
Assigned: rajab natshah » mohammed j. razem
Issue summary: View changes
Status: Active » Needs review
Issue tags: +varbase-10.0.0-beta1, +vartheme_bs5-3.0.0-alpha7
rajab natshah’s picture

Assigned: mohammed j. razem » Unassigned
Status: Needs review » Fixed
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Having a smoother out of the box working Generated theme management

How to use the Vartheme BS5 Starterkit

To generate a new theme from Vartheme BS5 using the starterkit/theme-generation script, run the following from Drupal's installation root:

cd PROJECT_DIR_NAME/docroot

Run the following Drupal Generate Theme script:
php core/scripts/drupal generate-theme new_theme_name --starterkit vartheme_bs5

rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes
rajab natshah’s picture

Issue summary: View changes

Only generative theme

Vartheme BS5 - Is only a starterkit and a drupal template mapper to ( include, embed, extend ) for SDC components by Varbase Components.

sonam_sharma made their first commit to this issue’s fork.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

Issue summary: View changes