Problem/Motivation
Experimented with the following
- #3366302: Add all Page components to Vartheme BS5
- #3366303: Remove all Page components out from Varbase Components to Vartheme BS5
But facing issue with starterkit generated themes and replacement of SDC components
From Varbase Components, Vartheme BS5 , and Generated theme
with duplicate SDC components or messing components
Proposed resolution
- Remove all SDC components out from Vartheme BS5 and include them from
Varbase Components - #3371836: Add all moved Vartheme BS5 components in Varbase Components with option to include or embed in Generated themes
Keep the Starterkit Vartheme BS5 inline with Varbase Components, for an out of the box working Generated theme.
Having a smoother out of the box working Generated theme management
How to use the Vartheme BS5 Starterkit
To generate a new theme from Vartheme BS5 using the starterkit/theme-generation script, run the following from Drupal's installation root:
cd PROJECT_DIR_NAME/docroot
Run the following Drupal Generate Theme script:
php core/scripts/drupal generate-theme new_theme_name --starterkit vartheme_bs5
Only generative theme
Vartheme BS5 - Is only a starterkit and a drupal template mapper to (
include,embed,extend) for SDC components by Varbase Components.
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ✅ Accessibility and Readability
- ✅ Code review from 1 Varbase core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release Varbase 10.0.0-beta1, vartheme_bs5-3.0.0-alpha7
Varbase update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- Issue #3371835: Removed all SDC components out from Vartheme BS5 and include them from Varbase Components for a smoother out of the box working Generated theme management
Issue fork vartheme_bs5-3371835
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rajab natshahComment #3
rajab natshahComment #5
rajab natshahComment #6
rajab natshahComment #7
rajab natshah✅ Released vartheme_bs5-3.0.0-alpha7
Comment #8
rajab natshahComment #9
rajab natshahHaving a smoother out of the box working Generated theme management
How to use the Vartheme BS5 Starterkit
To generate a new theme from Vartheme BS5 using the starterkit/theme-generation script, run the following from Drupal's installation root:
Run the following Drupal Generate Theme script:
php core/scripts/drupal generate-theme new_theme_name --starterkit vartheme_bs5Comment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #15
rajab natshah✅ Released Varbase 10.0.0-beta1