Problem/Motivation

This has been discussed with the security team and was agreed to be made public
The comment module has an access bypass vulnerability.

Steps to reproduce

1. Enabling the comment and jsonapi modules
2. Enabling "Accept all JSON:API create, read, update, and delete operations." for jsonapi module
3. Configure node type to receive comments
4. Create a node with comments status Closed
5. As a user with "Post comments" permission create comment through jsonapi

As a result, when comments status is Closed users should not be able to post comments, but jsonap module ignores this per-node configuration field. A similar issue with comments status is Hidden.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

larowlan created an issue. See original summary.

larowlan credited andypost.

larowlan credited Berdir.

larowlan credited dokumori.

larowlan credited greggles.

larowlan credited longwave.

larowlan’s picture

Crediting those involved in the private issue

larowlan’s picture

Status: Active » Needs review
StatusFileSize
new3.74 KB
new8.32 KB

The last submitted patch, 11: 3371464-172666-fail.patch, failed testing. View results

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Following the steps from the issue summary can confirm the #11 patch solves it.
The fail patch also shows the test coverage is good.

LGTM

The last submitted patch, 11: 3371464-172666-fail.patch, failed testing. View results

The last submitted patch, 11: 3371464-172666-fail.patch, failed testing. View results

  • catch committed 575a5342 on 10.1.x
    Issue #3371464 by larowlan, Berdir, benjifisher, andypost, dokumori,...

  • catch committed e9a09ddd on 11.x
    Issue #3371464 by larowlan, Berdir, benjifisher, andypost, dokumori,...
catch’s picture

Version: 11.x-dev » 10.1.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.