Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0
Proposed resolution
- Update
core/package.json cd coreyarn installyarn buildyarn build:ckeditor5-types
Remaining tasks
User interface changes
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3370989-2.patch | 2.44 MB | lauriii |
Comments
Comment #2
lauriiiChecking what testbot thinks 🤞
Comment #3
wim leersThank you, you beat me to it! 😄
If all is well, then this release with NO major breaking changes (which they explicitly did at our request to address as many of the most-upgrade-blocking problems in #3340578: [meta] [upstream] Prioritized CKEditor 5 upstream blockers as possible during 10.1 rather than waiting for Drupal 10.2 in December! 🙏👍) fixes:
Style-support-for-<div>problem: applying a class to a div now works using the UI! #3326261-51: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elementsThat's 3 issues that are often blocking the switch from CKEditor 4 to 5 solved, one of which is a data loss bug.
Ideally, this release would ship in Drupal
10.1.1!Comment #4
wim leersGiven that this fixes a critical data loss bug (#3349893: [upstream] [GHS] CKEditor 5 removes <a>s that wrap HTML elements not natively supported by CKEditor 5), bumping to .
Since this passes tests, RTBC'ing.
Comment #5
lauriiiIt looks like core is not impacted by this even though we are using
htmlAttributesfor Drupal Media. This is because we are adding our own use of this attribute, and the underlying APIs are not tied into a specific attribute name.It does look like this will break at least UI Styles contrib module but it's used by 414 sites. Ideal way to address this would be to remove their usage of
htmlAttributesand use the CKEditor 5 core APIs instead.Comment #6
catchCan we open an issue against UI Styles (not necessarily with a patch but at least a heads up)?
Comment #7
catchSpoke to @lauriii in irc, UI Styles is still in the progress of updating for 10.1, so we wouldn't be breaking existing sites that use it. Given this fixes critical data loss bugs, I think we should just go ahead and commit it to 10.1.x - but asap so it gets into 10.1.1 where most sites will still be updating from 10.0.x (or 9.5.x) to 10.1.1 rather than just the patch release.
Comment #8
lauriiiI did some manual testing to confirm that the issues mentioned in #3 are indeed solved. It looks like there's really good progress there! I wasn't able to convert an existing element to a
<div>which is needed to be able to close #3326261: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements. Applying styles to<ul>and<table>worked just as I would have expected. 🤩 Confirmed also that wrapping<a>for elements not supported by CKEditor 5 are retained.Comment #11
catchCommitted/pushed to 11.x and cherry-picked to 10.1.x, thanks!
Comment #12
wim leers#7++ — that's exactly the rationale I mentioned to @lauriii too :)
#8:
Yes, I called that out in detail over at #3326261-51: [Style] Add tests for inability to apply styles to <div>, <ul>, <ol>, <table> etc. in CKEditor 5 — and <a> allows applying it to all elements. But the critical data loss part is solved 👍
Comment #14
wim leers