----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
13 | ERROR | [x] list(...) is forbidden, use [...] instead.
----------------------------------------------------------------------

-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\add_translation\AddTranslation.
-------------------------------------------------------------------------------------------------------------------------------

--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
146 | WARNING | [ ] #options values usually have to run through t() for translation
--------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#5 3368876-4.patch6.78 KBbharath-kondeti
#3 3368876-after-patch.png274.36 KBclarkssquared
#2 3368876-2-fixed-issues-reported-by-phpcs.patch1.93 KBvishal365365

Issue fork add_translation-3368876

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vishal365365 created an issue. See original summary.

vishal365365’s picture

vishal365365 commented
Assigned: vishal365365 » Unassigned
Status: Active » Needs review
StatusFileSize
new 3368876-2-fixed-issues-reported-by-phpcs.patch1.93 KB

issues fixed

clarkssquared’s picture

clarkssquared commented
Status: Needs review » Needs work
StatusFileSize
new 3368876-after-patch.png274.36 KB

Hi vishal365365

I applied your patch #2 to my local and noticed that there are still PHPCS issues being reported.

Please look at the screenshot attached for your reference

Thank you

bharath-kondeti made their first commit to this issue’s fork.

bharath-kondeti’s picture

bharath-kondeti commented
StatusFileSize
new 3368876-4.patch6.78 KB

Addressed all the issues. Please review the patch

bharath-kondeti opened merge request !1

bharath-kondeti’s picture

bharath-kondeti commented
Status: Needs work » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: issues reported by phpcs » Fix the issues reported by phpcs
Status: Needs review » Needs work
Issue tags: +Coding standards, +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Normal » Minor

  • jayprakash01 committed 12b3a542 on 1.0.x 
    Issue #3368876 by bharath-kondeti: Fix the issues reported by phpcs
jayprakash01’s picture

jayprakash01 commented
Version: 1.0.x-dev » 1.0.1
Status: Needs work » Needs review

The patch has been applied, and the release has been made with a new tag.

jayprakash01 closed merge request !1

jayprakash01’s picture

jayprakash01 commented
Status: Needs review » Fixed

This is fixed now. Hence closing this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.