Run this command in the module folder: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,css,js,twig,txt,md,yml

FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/footable/footable.module
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 145 | WARNING | Only string literals should be passed to t() where possible
-------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/footable/src/Form/FooTableBreakpointEditForm.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------
  8 | WARNING | [x] Unused use statement
 20 | ERROR   | [x] Data types in @var tags need to be fully namespaced
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/footable/src/FooTableBreakpointInterface.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 32 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------------


FILE: /Users/studenttrainees/Drupal.org/drupalorg-site/docroot/modules/contrib/footable/src/Plugin/views/style/FooTable.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
 380 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------

Time: 351ms; Memory: 12MB
CommentFileSizeAuthor
#2 phpcs-3367790-2.patch3.15 KBparaderojether

Issue fork footable-3367790

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

paraderojether created an issue. See original summary.

paraderojether’s picture

paraderojether commented
Assigned: paraderojether » Unassigned
Status: Active » Needs review
StatusFileSize
new phpcs-3367790-2.patch3.15 KB

Created a patch to fix issues reported by phpcs.

Please review.
Thank You.

Anmol_Specbee’s picture

Anmol_Specbee commented
Status: Needs review » Reviewed & tested by the community

The patch#2 seems to be working fine, Moving it to RTBC

just-me’s picture

just-me commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
Assigned: Unassigned » just-me

The version was changed to 8.x-2.x-dev due to the new one.

just-me’s picture

just-me commented
Status: Reviewed & tested by the community » Active

just-me opened merge request !10

just-me’s picture

just-me commented
Assigned: just-me » Unassigned
Status: Active » Needs review

I've applied phpcs standards to the 8.x-2.x.

quadrexdev’s picture

quadrexdev
Location Lutsk
commented

Looks good now

schillerm’s picture

schillerm commented
Status: Needs review » Reviewed & tested by the community

Hi, yes also checked this and phpcs is passing ..

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml web/modules/contrib/footable

FILE: /home/m/Documents/Issues/footable-10-3367790/web/modules/contrib/footable/footable.module
-----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------
176 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------

Time: 608ms; Memory: 12MB

Moving to RTBC.

  • just-me committed 520a2a66 on 8.x-2.x 
    feat: #3367790 Fix the issues reported by phpcs
just-me’s picture

just-me commented
Status: Reviewed & tested by the community » Fixed

Merged, thanks to everyone.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

just-me’s picture

just-me commented
Assigned: Unassigned » just-me
Status: Fixed » Needs work

FILE: footable.module
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
178 | WARNING | Only string literals should be passed to t() where possible
| | (Drupal.Semantics.FunctionT.NotLiteralString)

We can delete t(). Translation will be provided by the schema with the label type.

just-me’s picture

just-me commented
Assigned: just-me » Unassigned
Status: Needs work » Fixed

Reverting to Fixed. The original issue is resolved and merged. The remaining minor PHPCS warning for the placeholder will be fixed as a direct follow-up commit in the new 3.0.x branch.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.