Problem/Motivation

Currently, we are getting the riddles inside "riddler_captcha()" through loading all riddles and then filtering them by status.

Steps to reproduce

Proposed resolution

Instead, we should just load all activated riddles straight away.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork riddler-3366659

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grevil created an issue. See original summary.

Grevil opened merge request !30

grevil’s picture

grevil commented
Status: Active » Needs review

Fixed. Please review!

grevil’s picture

grevil commented

We should also cherry-pick this into 2.x, once reviewed.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

RTBC! :)

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Done! Crediting me also as I found it, yesterday :P

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

  • Anybody committed 35c70992 on 3.x authored by Grevil 
    Issue #3366659 by Grevil, Anybody: Unnecessary loop in riddler_captcha...

  • Grevil committed 58a96b19 on 2.x 
    Issue #3366659 by Grevil, Anybody: Unnecessary loop in riddler_captcha...
grevil’s picture

grevil commented

Very nice! Lets create the releases! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.