Problem/Motivation

If a module like https://www.drupal.org/project/rename_admin_paths is used to change the path /user. Then Gin Login templates overrides are not taken into account anymore because they are based on the path.

Steps to reproduce

- add the Rename Admin Paths module
- enable "Rename use path".

Proposed resolution

Add template suggestion based on the route name, so it will be valid anytime.

Remaining tasks

Implements solution

CommentFileSizeAuthor
#4 gin_login-3366432-4.patch1.19 KBgrimreaper

Issue fork gin_login-3366432

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Grimreaper created an issue. See original summary.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

Grimreaper opened merge request !26

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Active » Needs review
StatusFileSize
new gin_login-3366432-4.patch1.19 KB

MR created.

Attaching patch for easier Composer usage.

Thanks for the review!

glynster’s picture

glynster commented

@Grimreaper, this patch works a treat and is a very simple and elegant addition! RTBC +1.

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Related issues: +#3373127: Gin login route extension for custom based urls

saschaeggi made their first commit to this issue’s fork.

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Needs review » Fixed

Seems I tried to add the new pipeline config in the wrong branch so it shows up here 😅

Sorry if you got endless notifications. Anyway this has been merged 👏

Thanks @Grimreaper @glynster

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented

No problem.

Thanks for the merge :)

glynster’s picture

glynster commented

Awesome, love the admin theme and this tiny tweak makes all the diff!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.