Problem/Motivation
When you are editing content on devices 64em or larger and hide the sidebar, the content in the sidebar can still be tabbed to. This is an accessibility issue as these fields are read out to assistive technology users, even though that content is not intended to be interacted with. Additionally, this is an inconvenience to any users using tab to navigate.
Steps to reproduce
1. Open a browser window larger than 64em
2. Create new content
3. Hide the sidebar
4. Tab through the fields in the content editing view
Observe that you must tab several times before reaching new buttons.
If using a screenreader, observe something like this being read out as you tab through:
Revision log message edit multi line Briefly describe the changes you have made. blank
Save as: combo box Draft collapsed
Review dateNot reviewed yet toggle button pressed expanded
Content reviewed check box not checked I have reviewed this content.
Menu settingsNot in menu toggle button not pressed collapsed
Proposed resolution
CSS change to set the content of the sidebar as visibility: hidden or similar when the sidebar is closed.
Issue fork gin-3366228
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 8.x-3.x
changes, plain diff MR !261
- 3366228-non-visible-fields-are
changes, plain diff MR !260
Comments
Comment #3
keelanfh commentedComment #6
keelanfh commentedComment #7
Moni_10 commented@keelanfh The MR! 260 is working fine. Moving it to RTBC. Attaching working screen recording as well.
Comment #10
saschaeggiGreat a11y fix – thank you @keelanfh 👏
Comment #11
keelanfh commentedThanks for merging so quickly @saschaeggi !