Fix the issues reported by phpcs [#3366199]

Problem/Motivation

FILE: /Users/specbee/Sites/Projects/admin_toolbar/js/jquery.hoverIntent.js
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 67 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/admin_toolbar/admin_toolbar_search/css/admin.toolbar_search.css
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
 91 | ERROR | [x] Expected 0 spaces before semicolon in style definition; 1 found
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js
-------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------
 13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 61 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------


FILE: /Users/specbee/Sites/Projects/admin_toolbar/admin_toolbar_tools/src/AdminToolbarToolsHelper.php
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
 117 | WARNING | Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------------------------------

Time: 784ms; Memory: 16MB

Steps to reproduce

Run following command
phpcs --standard=“Drupal,DrupalPractice” --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js .

Comment	File	Size	Author
#16	Screenshot 2023-06-15 at 5.46.18 PM.png	936.62 KB	ashutosh ahirwal
#14	3366199-12.patch	1021 bytes	prabuela
#12	3366199-11.patch	1.11 KB	prabuela
#10	3366199-10.patch	1.26 KB	bhaveshithape
#8	Screenshot from 2023-06-13 17-30-25.png	46.1 KB	nitin_lama
#2	admin_toolbar-phpcs-code-standard-issue-3366199-#2-10.0.9.patch	2.57 KB	prachi6824

Issue fork admin_toolbar-3366199

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3366199-phpcs-code-standard

changes, plain diff MR !60

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

12 June 2023 at 11:55

prachi6824 created an issue. See original summary.

Comment #2

prachi6824 commented 12 June 2023 at 12:13

Status	File	Size
new	admin_toolbar-phpcs-code-standard-issue-3366199-#2-10.0.9.patch	2.57 KB

Hello,

I have created a patch to solve all the errors related to phpcs code standard.

Comment #4

12 June 2023 at 13:09

sourabhjain opened merge request !60

Comment #5

sourabhjain

English

commented 12 June 2023 at 13:13

Assigned:	sourabhjain	» Unassigned
Status:	Needs work	» Needs review

Comment #6

avpaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

commented 12 June 2023 at 19:17

Title:	Phpcs Code Standard Issue	» Fix the issues reported by phpcs
Category:	Bug report	» Task
Status:	Needs review	» Needs work
Issue tags:		+Coding standards, +Needs issue summary update

The issue summary should always describe what the issue is trying to fix and, in the case of coding standards issues, show which command and arguments have been used and which report that command shown. In this way, project maintainers can verify the patch/MR fixes all the warnings/errors.

Comment #7

nitin_lama

he/him

India

commented 13 June 2023 at 12:00

Assigned:

Unassigned

» nitin_lama

Comment #8

nitin_lama

he/him

India

commented 13 June 2023 at 12:04

Status	File	Size
new	Screenshot from 2023-06-13 17-30-25.png	46.1 KB

Found one error remaining. Committing changes in the MR.

validation

Comment #9

nitin_lama

he/him

India

commented 13 June 2023 at 12:05

Assigned:

nitin_lama

» Unassigned

Comment #10

bhaveshithape commented 15 June 2023 at 03:52

Status	File	Size
new	3366199-10.patch	1.26 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	admin_toolbar-phpcs-code-standard-issue-3366199-#2-10.0.9.patch	2.57 KB

Patch to solve all the errors related to phpcs code standard.
Not interdiff because none of the above patch applied.

Comment #11

bhaveshithape commented 15 June 2023 at 03:54

Status:

Needs work

» Needs review

Comment #12

prabuela commented 15 June 2023 at 05:11

Assigned:

Unassigned

» prabuela

Status	File	Size
new	3366199-11.patch	1.11 KB

Comment #13

prabuela commented 15 June 2023 at 05:11

Assigned:

prabuela

» Unassigned

Comment #14

prabuela commented 15 June 2023 at 05:56

Status	File	Size
new	3366199-12.patch	1021 bytes

1 file was hidden/shown/deleted

Status	File	Size
hidden	3366199-11.patch	1.11 KB

Comment #15

15 June 2023 at 06:00

Status:

Needs review

» Needs work

The last submitted patch, 14: 3366199-12.patch, failed testing. View results

Comment #16

ashutosh ahirwal commented 15 June 2023 at 12:17

Issue summary:

View changes

Status	File	Size
new	Screenshot 2023-06-15 at 5.46.18 PM.png	936.62 KB

Addressing #6 and updating issue summary and required command with arguments.
Please review.

Comment #17

imustakim commented 18 June 2023 at 06:59

Issue summary:	View changes
Issue tags:	-Needs issue summary update

Issue summary updated.

Comment #18

25 July 2023 at 11:37

keshav.k made their first commit to this issue’s fork.

Comment #19

keshavv commented 25 July 2023 at 11:42

Status:

Needs work

» Needs review

Updated MR !60 with latest changes.

I have scanned the module against 3.x branch with phpcs ../vendor/bin/phpcs --standard=drupal modules/contrib/admin_toolbar and fix the remaining issues.
Please do not fix the following JS issues, As it will throw a JS error.

FILE: /var/www/html/web/modules/contrib/admin_toolbar/js/jquery.hoverIntent.js
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
 67 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: /var/www/html/web/modules/contrib/admin_toolbar/admin_toolbar_search/js/admin_toolbar_search.js
-----------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------
 13 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 61 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-----------------------------------------------------------------------------------------------------

Please review.
Thank you.

Comment #20

aayushmankotia commented 28 July 2023 at 07:30

Status:

Needs review

» Reviewed & tested by the community

I've conducted a local test and everything is functioning as expected. It's only presenting JavaScript errors, which we don't require to rectify.
It appears ready to be transitioned to RTBC

Comment #21

29 September 2023 at 16:44

adriancid committed 33b281b2 on 3.x

Issue #3366199 by sourabhjain, PrabuEla, nitin_lama, prachi6824, keshavv...

Comment #22

adriancid

Spanish

Qc, Canada 🇨🇦

commented 29 September 2023 at 16:45

Status:

Reviewed & tested by the community

» Fixed

Comment #23

13 October 2023 at 16:49

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #24

16 April 2025 at 21:25

dydave closed merge request !60

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Issue fork admin_toolbar-3366199

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Comment #16

Comment #17

Comment #18

Comment #19

Comment #20

Comment #21

Comment #22

Comment #23

Comment #24

News items

Our community

Documentation

Drupal code base

Governance of community