Problem/Motivation

New patches are required to make this project installable.

Steps to reproduce

  1. Try to run Composer with composer.libraries.json included on any active Drupal core branch.
  2. Try enabling the schemadotorg_demo module with Drush.

Proposed resolution

Add new patches and update instructions.

Issue fork schemadotorg_demo-3366108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Darren Oh created an issue. See original summary.

Darren Oh opened merge request !4

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Core patches not applying » Fix not being able to install project
Assigned: darren oh » Unassigned
Status: Active » Needs review
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
jrockowitz’s picture

jrockowitz commented

For reference, what version of Drupal are you using? 9.5.x or 10.x?

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

I tried 9.5.x, 10.0.x, and 10.1.x. I tested the updated patches and instructions on 10.1.x. Need to test whether they work on 10.0.x and 9.5.x.

jrockowitz’s picture

jrockowitz commented

The entity embed module is not available to 10.x but we should support 9.x and 10.x. Thanks for your help.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

Only works with 10.1.x because the patch for #3151534: "Add another item" field button is displayed as a modal action can only work with one version.

Darren Oh opened merge request !5

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
jrockowitz’s picture

jrockowitz commented

@DarrenOh What should we do about support 9.5.x and 10.x?

We could add version numbers to the composer.libraries.json.

I am included to support only 9.5.x until this ticket is resolved
#3354295: Support Drupal 10

jrockowitz’s picture

jrockowitz commented

Hey, entity embed is now D10 compatible.

https://www.drupal.org/project/entity_embed/releases/8.x-1.4

I think we should move the demo and all the schemadotorg code to be only for D10.

What do you think?

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

D10 only sounds good for now. I like the idea of version numbers on composer.libraries.json. I'm still working on the 3366108-not-installable-10.0.x branch. Once I have that working smoothly, I can try a D9 version.

jrockowitz’s picture

jrockowitz commented

@Darren Oh Let me see if I can use the PR AS-IS and get everything working via D10.

jrockowitz’s picture

jrockowitz commented

Only works with 10.1.x because the patch for #3151534: "Add another item" field button is displayed as a modal action can only work with one version.

How about we move this patch for 9.5.x and 10.1.x to a composer.patches.VERSION.json file?

This will reduce code duplication.

BTW, I am not following which branch should be merged and we should reference to *.patch files and *.diff which can change.

Darren Oh opened merge request !6

jrockowitz’s picture

jrockowitz commented

Which MR should be merged?

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented

Depends on the Drupal version you choose to support. I'm updating to just one merge request with versioned composer.libraries.json files. Curious about your idea for reducing code duplication. Can we discuss on Slack?

Darren Oh closed merge request !6

Darren Oh closed merge request !5

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Fix not being able to install project » Fix installation not working

Consolidated into one merge request.

jrockowitz’s picture

jrockowitz commented

Thank you for merging the requests. I am going to test the changes and make some minor tweaks.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Issue summary: View changes
jrockowitz’s picture

jrockowitz commented

I would like to merge the patch and then make more minor tweaks as needed.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.